* [ia64][patch] Refuse inserting kprobe on slot 1 - take 2
@ 2005-06-24 16:58 Rusty Lynch
0 siblings, 0 replies; only message in thread
From: Rusty Lynch @ 2005-06-24 16:58 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-ia64, anil.s.keshavamurthy
Without the ability to atomically write 16 bytes, we can not update the
middle slot of a bundle, slot 1, unless we stop the machine first. This
patch will ensure the ability to robustly insert and remove a kprobe by
refusing to insert a kprobe on slot 1 until a mechanism is in place to
safely handle this case.
--rusty
Signed-off-by: Rusty Lynch <rusty.lynch@intel.com>
arch/ia64/kernel/kprobes.c | 7 +++++++
1 files changed, 7 insertions(+)
Index: linux-2.6.12-mm1/arch/ia64/kernel/kprobes.c
=================================--- linux-2.6.12-mm1.orig/arch/ia64/kernel/kprobes.c
+++ linux-2.6.12-mm1/arch/ia64/kernel/kprobes.c
@@ -270,6 +270,13 @@ static int valid_kprobe_addr(int templat
addr);
return -EINVAL;
}
+
+ if (slot = 1 && bundle_encoding[template][1] != L) {
+ printk(KERN_WARNING "Inserting kprobes on slot #1 "
+ "is not supported\n");
+ return -EINVAL;
+ }
+
return 0;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-24 16:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-24 16:58 [ia64][patch] Refuse inserting kprobe on slot 1 - take 2 Rusty Lynch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox