From: Ashok Raj <ashok.raj@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Fix undefined reference to can_cpei_retarget for simulator build
Date: Thu, 14 Jul 2005 16:02:07 +0000 [thread overview]
Message-ID: <20050714090206.A1155@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050714040909.GB15249@cse.unsw.EDU.AU>
On Thu, Jul 14, 2005 at 02:09:10PM +1000, Ian Wienand wrote:
> Hi,
>
> The change @ http://tinyurl.com/dsxf4 broke the simulator build
> (http://www.gelato.unsw.edu.au/kerncomp).
>
> The simulator build doesn't turn on ACPI, so doesn't have a definition
> of can_cpei_retarget. Suggested patch attached.
Sorry about that, never compiled for the simulator yet.
You might want to send this with the Signed-off-by signature as specified
in Documentation/SubmittingPatches.
thanks for fixing this.
Cheers,
ashok
>
> Thanks,
>
> -i
> ianw@gelato.unsw.edu.au
> http://www.gelato.unsw.edu.au
> diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c
> --- a/arch/ia64/kernel/topology.c
> +++ b/arch/ia64/kernel/topology.c
> @@ -36,12 +36,14 @@ int arch_register_cpu(int num)
> parent = &sysfs_nodes[cpu_to_node(num)];
> #endif /* CONFIG_NUMA */
>
> +#ifdef CONFIG_ACPI_BOOT
> /*
> * If CPEI cannot be re-targetted, and this is
> * CPEI target, then dont create the control file
> */
> if (!can_cpei_retarget() && is_cpu_cpei_target(num))
> sysfs_cpus[num].cpu.no_control = 1;
> +#endif
>
> return register_cpu(&sysfs_cpus[num].cpu, num, parent);
> }
--
Cheers,
Ashok Raj
- Open Source Technology Center
next prev parent reply other threads:[~2005-07-14 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-14 4:09 Fix undefined reference to can_cpei_retarget for simulator build Ian Wienand
2005-07-14 16:02 ` Ashok Raj [this message]
2005-07-14 19:21 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050714090206.A1155@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox