Fix undefined reference to can_cpei_retarget for simulator build

Fix undefined reference to can_cpei_retarget for simulator build

[Ian Wienand]

[-- Attachment #1.1: Type: text/plain, Size: 299 bytes --]

Hi,

The change @ http://tinyurl.com/dsxf4 broke the simulator build
(http://www.gelato.unsw.edu.au/kerncomp).

The simulator build doesn't turn on ACPI, so doesn't have a definition
of can_cpei_retarget.  Suggested patch attached.

Thanks,

-i
ianw@gelato.unsw.edu.au
http://www.gelato.unsw.edu.au

[-- Attachment #1.2: topology.c-acpi.diff --]
[-- Type: text/plain, Size: 563 bytes --]

diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c
--- a/arch/ia64/kernel/topology.c
+++ b/arch/ia64/kernel/topology.c
@@ -36,12 +36,14 @@ int arch_register_cpu(int num)
 	parent = &sysfs_nodes[cpu_to_node(num)];
 #endif /* CONFIG_NUMA */
 
+#ifdef CONFIG_ACPI_BOOT
 	/*
 	 * If CPEI cannot be re-targetted, and this is
 	 * CPEI target, then dont create the control file
 	 */
 	if (!can_cpei_retarget() && is_cpu_cpei_target(num))
 		sysfs_cpus[num].cpu.no_control = 1;
+#endif
 
 	return register_cpu(&sysfs_cpus[num].cpu, num, parent);
 }

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Fix undefined reference to can_cpei_retarget for simulator build

[Ashok Raj]

On Thu, Jul 14, 2005 at 02:09:10PM +1000, Ian Wienand wrote:
> Hi,
> 
> The change @ http://tinyurl.com/dsxf4 broke the simulator build
> (http://www.gelato.unsw.edu.au/kerncomp).
> 
> The simulator build doesn't turn on ACPI, so doesn't have a definition
> of can_cpei_retarget.  Suggested patch attached.

Sorry about that, never compiled for the simulator yet.

You might want to send this with the Signed-off-by signature as specified
in Documentation/SubmittingPatches.

thanks for fixing this.

Cheers,
ashok

> 
> Thanks,
> 
> -i
> ianw@gelato.unsw.edu.au
> http://www.gelato.unsw.edu.au

> diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c
> --- a/arch/ia64/kernel/topology.c
> +++ b/arch/ia64/kernel/topology.c
> @@ -36,12 +36,14 @@ int arch_register_cpu(int num)
>  	parent = &sysfs_nodes[cpu_to_node(num)];
>  #endif /* CONFIG_NUMA */
>  
> +#ifdef CONFIG_ACPI_BOOT
>  	/*
>  	 * If CPEI cannot be re-targetted, and this is
>  	 * CPEI target, then dont create the control file
>  	 */
>  	if (!can_cpei_retarget() && is_cpu_cpei_target(num))
>  		sysfs_cpus[num].cpu.no_control = 1;
> +#endif
>  
>  	return register_cpu(&sysfs_cpus[num].cpu, num, parent);
>  }




-- 
Cheers,
Ashok Raj
- Open Source Technology Center

RE: Fix undefined reference to can_cpei_retarget for simulator build

[Luck, Tony]

>> The simulator build doesn't turn on ACPI, so doesn't have a definition
>> of can_cpei_retarget.  Suggested patch attached.
>
>Sorry about that, never compiled for the simulator yet.
>
>You might want to send this with the Signed-off-by signature as specified
>in Documentation/SubmittingPatches.
>
>thanks for fixing this.

For a simple fix like this I'll *sometimes* put my name at the
head of the blame trail and commit it with just my "Signed-off-by"
(but still credit the real author).  I did it for this one, but
in general it is a whole lot faster/easier if people remember to
include their own sign off line.

-Tony