* Re: [PATCH 05/15] ia64: remove use of asm/segment.h
2005-08-24 16:53 ` [PATCH 05/15] ia64: remove use of asm/segment.h Kumar Gala
@ 2005-08-24 20:09 ` Bjorn Helgaas
2005-08-24 22:49 ` Ralf Baechle
2005-08-24 20:19 ` Luck, Tony
2005-08-24 21:42 ` Luck, Tony
2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2005-08-24 20:09 UTC (permalink / raw)
To: Kumar Gala; +Cc: linux-kernel, Andrew Morton, tony.luck, linux-ia64
On Wednesday 24 August 2005 10:53 am, Kumar Gala wrote:
> Removed IA64 architecture specific users of asm/segment.h and
> asm-ia64/segment.h itself
I posted a similar patch a month ago, but I only removed the
arch/ia64 includes of asm/segment.h.
There are still a few drivers that include asm/segment.h, so
I don't think we should remove asm/segment.h itself just yet.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/15] ia64: remove use of asm/segment.h
2005-08-24 20:09 ` Bjorn Helgaas
@ 2005-08-24 22:49 ` Ralf Baechle
0 siblings, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2005-08-24 22:49 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Kumar Gala, linux-kernel, Andrew Morton, tony.luck, linux-ia64
On Wed, Aug 24, 2005 at 02:09:55PM -0600, Bjorn Helgaas wrote:
> On Wednesday 24 August 2005 10:53 am, Kumar Gala wrote:
> > Removed IA64 architecture specific users of asm/segment.h and
> > asm-ia64/segment.h itself
>
> I posted a similar patch a month ago, but I only removed the
> arch/ia64 includes of asm/segment.h.
>
> There are still a few drivers that include asm/segment.h, so
> I don't think we should remove asm/segment.h itself just yet.
<asm/segment.h> was replaced by <asm/uaccess.h> in 2.1.4 and we still have
references ...
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 05/15] ia64: remove use of asm/segment.h
2005-08-24 16:53 ` [PATCH 05/15] ia64: remove use of asm/segment.h Kumar Gala
2005-08-24 20:09 ` Bjorn Helgaas
@ 2005-08-24 20:19 ` Luck, Tony
2005-08-24 21:32 ` Kumar Gala
2005-08-24 21:42 ` Luck, Tony
2 siblings, 1 reply; 6+ messages in thread
From: Luck, Tony @ 2005-08-24 20:19 UTC (permalink / raw)
To: Bjorn Helgaas, Kumar Gala; +Cc: linux-kernel, Andrew Morton, linux-ia64
>There are still a few drivers that include asm/segment.h, so
>I don't think we should remove asm/segment.h itself just yet.
Agreed. The sequence should be to send patches to get rid of
all "#include <asm/segment.h>" references.
Once they have all gone, then a patch can remove the files.
If you are concerned that people would start adding new
references and you don't want to get into a game of whack-a-mole,
then you could add #warning "include of deprecated asm/segment.h",
but that might be overkill.
I'll apply this for ia64 w/o the deletion.
-Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 05/15] ia64: remove use of asm/segment.h
2005-08-24 20:19 ` Luck, Tony
@ 2005-08-24 21:32 ` Kumar Gala
0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2005-08-24 21:32 UTC (permalink / raw)
To: Luck, Tony
Cc: Bjorn Helgaas, Gala Kumar K.-galak, linux-kernel, Andrew Morton,
linux-ia64
On Aug 24, 2005, at 3:19 PM, Luck, Tony wrote:
>> There are still a few drivers that include asm/segment.h, so
>> I don't think we should remove asm/segment.h itself just yet.
>>
>
> Agreed. The sequence should be to send patches to get rid of
> all "#include <asm/segment.h>" references.
>
> Once they have all gone, then a patch can remove the files.
>
> If you are concerned that people would start adding new
> references and you don't want to get into a game of whack-a-mole,
> then you could add #warning "include of deprecated asm/segment.h",
> but that might be overkill.
>
> I'll apply this for ia64 w/o the deletion.
I've posted a patch before this to remove all non-architecture users
of asm/segment.h.
http://www.ussg.iu.edu/hypermail/linux/kernel/0508.3/0099.html
- kumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 05/15] ia64: remove use of asm/segment.h
2005-08-24 16:53 ` [PATCH 05/15] ia64: remove use of asm/segment.h Kumar Gala
2005-08-24 20:09 ` Bjorn Helgaas
2005-08-24 20:19 ` Luck, Tony
@ 2005-08-24 21:42 ` Luck, Tony
2 siblings, 0 replies; 6+ messages in thread
From: Luck, Tony @ 2005-08-24 21:42 UTC (permalink / raw)
To: Kumar Gala
Cc: Bjorn Helgaas, Gala Kumar K.-galak, linux-kernel, Andrew Morton,
linux-ia64
>> I'll apply this for ia64 w/o the deletion.
This is now in my test tree. I will send to Linus soon after
2.6.13 is released.
>I've posted a patch before this to remove all non-architecture users
>of asm/segment.h.
>
>http://www.ussg.iu.edu/hypermail/linux/kernel/0508.3/0099.html
Good. After that gets I applied I will delete include/asm-ia64/segment.h
-Tony
^ permalink raw reply [flat|nested] 6+ messages in thread