From: "John W. Linville" <linville@tuxdriver.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
discuss@x86-64.org, linux-ia64@vger.kernel.org,
Asit.K.Mallick@intel.com, goutham.rao@intel.com,
davidm@hpl.hp.com
Subject: Re: [patch 2.6.13] swiotlb: add swiotlb_sync_single_range_for_{cpu,device}
Date: Tue, 30 Aug 2005 18:09:14 +0000 [thread overview]
Message-ID: <20050830180912.GE18998@tuxdriver.com> (raw)
In-Reply-To: <B8E391BBE9FE384DAA4C5C003888BE6F0443A4B5@scsmsx401.amr.corp.intel.com>
On Tue, Aug 30, 2005 at 11:03:35AM -0700, Luck, Tony wrote:
>
> >+swiotlb_sync_single_range_for_cpu(struct device *hwdev,
> >+swiotlb_sync_single_range_for_device(struct device *hwdev,
>
> Huh? These look identical ... same args, same code, just a
> different name.
Have you looked at the implementations for swiotlb_sync_single_for_cpu
and swiotlb_sync_single_for_device? Those are already identical.
I'm just following the existing style/practice in that file. I could
do an additional patch to rectify the replication in those functions
if you'd like?
Who is responsible for the swiotlb code?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-08-30 18:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050829200916.GI3716@tuxdriver.com>
[not found] ` <200508292254.53476.ak@suse.de>
[not found] ` <20050829214828.GA6314@tuxdriver.com>
[not found] ` <200508300314.35177.ak@suse.de>
[not found] ` <20050830175436.GB18998@tuxdriver.com>
2005-08-30 17:58 ` [patch 2.6.13] swiotlb: add swiotlb_sync_single_range_for_{cpu,device} John W. Linville
2005-08-30 18:03 ` Luck, Tony
2005-08-30 18:09 ` John W. Linville [this message]
2005-08-30 18:33 ` [rfc patch] swiotlb: consolidate swiotlb_sync_single_* implementations John W. Linville
2005-08-30 18:40 ` [rfc patch] swiotlb: consolidate swiotlb_sync_sg_* implementations John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 1/6] swiotlb: move from arch/ia64/lib to lib John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 2/6] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 3/6] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 5/6] swiotlb: file header comments John W. Linville
2005-09-12 18:51 ` [patch 2.6.13 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings Grant Grundler
2005-09-12 19:51 ` John W. Linville
2005-09-12 19:53 ` [patch 2.6.13] swiotlb: BUG() for DMA_NONE in sync_single John W. Linville
2005-09-12 20:23 ` Grant Grundler
2005-09-12 23:45 ` [patch 2.6.13 (take #2)] " John W. Linville
2005-09-12 23:59 ` Grant Grundler
2005-09-13 4:05 ` [discuss] " Andi Kleen
2005-09-22 20:37 ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Luck, Tony
2005-09-22 20:41 ` Christoph Hellwig
2005-09-23 18:22 ` John W. Linville
2005-09-23 18:31 ` Muli Ben-Yehuda
2005-09-23 18:27 ` Luck, Tony
2005-09-23 18:50 ` John W. Linville
2005-09-23 21:38 ` Grant Grundler
2005-09-26 7:01 ` Andi Kleen
2005-09-26 21:01 ` [patch 2.6.14-rc2 0/5] " John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 1/5] swiotlb: move from arch/ia64/lib to drivers/pci John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 2/5] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 3/5] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 4/5] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-26 21:01 ` [patch 2.6.14-rc2 5/5] swiotlb: file header comments John W. Linville
2005-09-26 21:33 ` [patch 2.6.14-rc2 0/5] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Matthew Wilcox
2005-09-26 21:54 ` John W. Linville
2005-09-26 22:08 ` Luck, Tony
2005-09-26 22:46 ` Grant Grundler
2005-09-27 0:14 ` John W. Linville
2005-09-27 2:47 ` Tony Luck
2005-09-28 21:50 ` [patch 2.6.14-rc2 0/6] " John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 1/6] swiotlb: move from arch/ia64/lib/ to lib/ John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 2/6] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 3/6] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-28 21:50 ` [patch 2.6.14-rc2 5/6] swiotlb: file header comments John W. Linville
2005-09-29 22:42 ` [patch 2.6.14-rc2 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050830180912.GE18998@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Asit.K.Mallick@intel.com \
--cc=ak@suse.de \
--cc=davidm@hpl.hp.com \
--cc=discuss@x86-64.org \
--cc=goutham.rao@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox