public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Grant Grundler <iod00d@hp.com>
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org,
	linux-ia64@vger.kernel.org, ak@suse.de, tony.luck@intel.com,
	Asit.K.Mallick@intel.com
Subject: [patch 2.6.13 (take #2)] swiotlb: BUG() for DMA_NONE in sync_single
Date: Mon, 12 Sep 2005 23:45:34 +0000	[thread overview]
Message-ID: <20050912234532.GH19644@tuxdriver.com> (raw)
In-Reply-To: <20050912202333.GF21820@esmail.cup.hp.com>

Call BUG() if DMA_NONE is passed-in as direction for sync_single.
Also remove unnecessary checks for DMA_NONE in callers of sync_single.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
This patch replaces the previous patch with (almost) the same subject.

 lib/swiotlb.c |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -315,13 +315,13 @@ sync_single(struct device *hwdev, char *
 	case SYNC_FOR_CPU:
 		if (likely(dir = DMA_FROM_DEVICE || dma = DMA_BIDIRECTIONAL))
 			memcpy(buffer, dma_addr, size);
-		else if (dir != DMA_TO_DEVICE && dir != DMA_NONE)
+		else if (dir != DMA_TO_DEVICE)
 			BUG();
 		break;
 	case SYNC_FOR_DEVICE:
 		if (likely(dir = DMA_TO_DEVICE || dma = DMA_BIDIRECTIONAL))
 			memcpy(dma_addr, buffer, size);
-		else if (dir != DMA_FROM_DEVICE && dir != DMA_NONE)
+		else if (dir != DMA_FROM_DEVICE)
 			BUG();
 		break;
 	default:
@@ -515,8 +515,6 @@ swiotlb_sync_single(struct device *hwdev
 {
 	char *dma_addr = phys_to_virt(dev_addr);
 
-	if (dir = DMA_NONE)
-		BUG();
 	if (dma_addr >= io_tlb_start && dma_addr < io_tlb_end)
 		sync_single(hwdev, dma_addr, size, dir, target);
 	else if (dir = DMA_FROM_DEVICE)
@@ -547,8 +545,6 @@ swiotlb_sync_single_range(struct device 
 {
 	char *dma_addr = phys_to_virt(dev_addr) + offset;
 
-	if (dir = DMA_NONE)
-		BUG();
 	if (dma_addr >= io_tlb_start && dma_addr < io_tlb_end)
 		sync_single(hwdev, dma_addr, size, dir, target);
 	else if (dir = DMA_FROM_DEVICE)
@@ -651,9 +647,6 @@ swiotlb_sync_sg(struct device *hwdev, st
 {
 	int i;
 
-	if (dir = DMA_NONE)
-		BUG();
-
 	for (i = 0; i < nelems; i++, sg++)
 		if (sg->dma_address != SG_ENT_PHYS_ADDRESS(sg))
 			sync_single(hwdev, (void *) sg->dma_address,
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2005-09-12 23:45 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050829200916.GI3716@tuxdriver.com>
     [not found] ` <200508292254.53476.ak@suse.de>
     [not found]   ` <20050829214828.GA6314@tuxdriver.com>
     [not found]     ` <200508300314.35177.ak@suse.de>
     [not found]       ` <20050830175436.GB18998@tuxdriver.com>
2005-08-30 17:58         ` [patch 2.6.13] swiotlb: add swiotlb_sync_single_range_for_{cpu,device} John W. Linville
2005-08-30 18:03           ` Luck, Tony
2005-08-30 18:09             ` John W. Linville
2005-08-30 18:33               ` [rfc patch] swiotlb: consolidate swiotlb_sync_single_* implementations John W. Linville
2005-08-30 18:40                 ` [rfc patch] swiotlb: consolidate swiotlb_sync_sg_* implementations John W. Linville
2005-09-12 14:48               ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} John W. Linville
2005-09-12 14:48                 ` [patch 2.6.13 1/6] swiotlb: move from arch/ia64/lib to lib John W. Linville
2005-09-12 14:48                   ` [patch 2.6.13 2/6] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-12 14:48                     ` [patch 2.6.13 3/6] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-12 14:48                       ` [patch 2.6.13 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-12 14:48                         ` [patch 2.6.13 5/6] swiotlb: file header comments John W. Linville
2005-09-12 18:51                         ` [patch 2.6.13 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings Grant Grundler
2005-09-12 19:51                           ` John W. Linville
2005-09-12 19:53                             ` [patch 2.6.13] swiotlb: BUG() for DMA_NONE in sync_single John W. Linville
2005-09-12 20:23                               ` Grant Grundler
2005-09-12 23:45                                 ` John W. Linville [this message]
2005-09-12 23:59                                   ` [patch 2.6.13 (take #2)] " Grant Grundler
2005-09-13  4:05                                   ` [discuss] " Andi Kleen
2005-09-22 20:37                 ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Luck, Tony
2005-09-22 20:41                   ` Christoph Hellwig
2005-09-23 18:22                     ` John W. Linville
2005-09-23 18:31                       ` Muli Ben-Yehuda
2005-09-23 18:27                 ` Luck, Tony
2005-09-23 18:50                   ` John W. Linville
2005-09-23 21:38                     ` Grant Grundler
2005-09-26  7:01                   ` Andi Kleen
2005-09-26 21:01                   ` [patch 2.6.14-rc2 0/5] " John W. Linville
2005-09-26 21:01                     ` [patch 2.6.14-rc2 1/5] swiotlb: move from arch/ia64/lib to drivers/pci John W. Linville
2005-09-26 21:01                       ` [patch 2.6.14-rc2 2/5] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-26 21:01                         ` [patch 2.6.14-rc2 3/5] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-26 21:01                           ` [patch 2.6.14-rc2 4/5] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-26 21:01                             ` [patch 2.6.14-rc2 5/5] swiotlb: file header comments John W. Linville
2005-09-26 21:33                     ` [patch 2.6.14-rc2 0/5] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Matthew Wilcox
2005-09-26 21:54                       ` John W. Linville
2005-09-26 22:08                     ` Luck, Tony
2005-09-26 22:46                       ` Grant Grundler
2005-09-27  0:14                         ` John W. Linville
2005-09-27  2:47                           ` Tony Luck
2005-09-28 21:50                             ` [patch 2.6.14-rc2 0/6] " John W. Linville
2005-09-28 21:50                               ` [patch 2.6.14-rc2 1/6] swiotlb: move from arch/ia64/lib/ to lib/ John W. Linville
2005-09-28 21:50                                 ` [patch 2.6.14-rc2 2/6] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-28 21:50                                   ` [patch 2.6.14-rc2 3/6] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-28 21:50                                     ` [patch 2.6.14-rc2 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-28 21:50                                       ` [patch 2.6.14-rc2 5/6] swiotlb: file header comments John W. Linville
2005-09-29 22:42                               ` [patch 2.6.14-rc2 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050912234532.GH19644@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=Asit.K.Mallick@intel.com \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=iod00d@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox