ia64: allnoconfig build fails

ia64: allnoconfig build fails

[Len Brown]

Volunteers?


mm/mempolicy.c: In function `huge_zonelist':
mm/mempolicy.c:1045: error: `HPAGE_SHIFT' undeclared (first use in this function)
mm/mempolicy.c:1045: error: (Each undeclared identifier is reported only once
mm/mempolicy.c:1045: error: for each function it appears in.)
make[1]: *** [mm/mempolicy.o] Error 1

RE: ia64: allnoconfig build fails

[Chen, Kenneth W]

Len Brown wrote on Saturday, January 21, 2006 12:20 AM
> mm/mempolicy.c: In function `huge_zonelist':
> mm/mempolicy.c:1045: error: `HPAGE_SHIFT' undeclared (first use in
this function)
> mm/mempolicy.c:1045: error: (Each undeclared identifier is reported
only once
> mm/mempolicy.c:1045: error: for each function it appears in.)
> make[1]: *** [mm/mempolicy.o] Error 1

Need to wrap huge_zonelist function with CONFIG_HUGETLBFS.


Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>


--- ./mm/mempolicy.c.orig	2006-01-21 11:00:30.000000000 -0800
+++ ./mm/mempolicy.c	2006-01-21 11:00:54.000000000 -0800
@@ -1034,6 +1034,7 @@ static inline unsigned interleave_nid(st
 		return interleave_nodes(pol);
 }
 
+#ifdef CONFIG_HUGETLBFS
 /* Return a zonelist suitable for a huge page allocation. */
 struct zonelist *huge_zonelist(struct vm_area_struct *vma, unsigned
long addr)
 {
@@ -1047,6 +1048,7 @@ struct zonelist *huge_zonelist(struct vm
 	}
 	return zonelist_policy(GFP_HIGHUSER, pol);
 }
+#endif
 
 /* Allocate a page in interleaved policy.
    Own path because it needs to do special accounting. */

RE: ia64: allnoconfig build fails

[Luck, Tony]

> Need to wrap huge_zonelist function with CONFIG_HUGETLBFS.
>
>
> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>

Fixes this new problem ... allnoconfig still fails for me
with lots of:

     undefined reference to `vmem_map'

and a few

     undefined reference to `ia64_pfn_valid'

but these have been around for a while.

-Tony

Re: ia64: allnoconfig build fails

[Andi Kleen]

On Saturday 21 January 2006 22:11, Luck, Tony wrote:
> > Need to wrap huge_zonelist function with CONFIG_HUGETLBFS.
> >
> >
> > Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
> 
> Fixes this new problem ... allnoconfig still fails for me
> with lots of:
> 
>      undefined reference to `vmem_map'
> 
> and a few
> 
>      undefined reference to `ia64_pfn_valid'
> 
> but these have been around for a while.

Trying without CONFIG_NUMA but with virtual memory map also doesn't work.
Also some of the other obvious combinations in the mm space are broken.
Found this last time I updated the kernel on my ia64 box.

-Andi

Re: ia64: allnoconfig build fails

[Robin Holt]

I think I used git bisect correctly and narrowed it down to
this commit:

1be7d9935b9c7fb9bd5964bfaf3ac543381277db

I would guess it is related to the change in pfn_valid around:

-#ifndef CONFIG_DISCONTIGMEM
+#ifdef CONFIG_FLATMEM
# define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
# define page_to_pfn(page) ((unsigned long) (page - mem_map))
# define pfn_to_page(pfn) (mem_map + (pfn))
-#else
+#elif defined(CONFIG_DISCONTIGMEM)

Thanks,
Robin Holt

On Sat, Jan 21, 2006 at 01:11:38PM -0800, Luck, Tony wrote:
> > Need to wrap huge_zonelist function with CONFIG_HUGETLBFS.
> >
> >
> > Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
> 
> Fixes this new problem ... allnoconfig still fails for me
> with lots of:
> 
>      undefined reference to `vmem_map'
> 
> and a few
> 
>      undefined reference to `ia64_pfn_valid'
> 
> but these have been around for a while.
> 
> -Tony
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ia64: allnoconfig build fails

[Andi Kleen]

On Saturday 21 January 2006 20:14, Chen, Kenneth W wrote:
> Len Brown wrote on Saturday, January 21, 2006 12:20 AM
> > mm/mempolicy.c: In function `huge_zonelist':
> > mm/mempolicy.c:1045: error: `HPAGE_SHIFT' undeclared (first use in
> this function)
> > mm/mempolicy.c:1045: error: (Each undeclared identifier is reported
> only once
> > mm/mempolicy.c:1045: error: for each function it appears in.)
> > make[1]: *** [mm/mempolicy.o] Error 1
> 
> Need to wrap huge_zonelist function with CONFIG_HUGETLBFS.

I queued it thanks. Unfortunately the patch was word wrapped and MIME damaged. 
I fixed this, but please be more careful with that next time.

Thanks,
-Andi