[patch] fix ia64_hint definition for intel compiler intrinsic

[patch] fix ia64_hint definition for intel compiler intrinsic

[Chen, Kenneth W]

Map ia64_hint() to internal intel compiler intrinsic.

Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>

---
Compile tested on selective files.  icc 9.0 appears to have
memory clobber behavior for the hint@pause intrinsic similar
to gcc with "memory" clobber modifier. Your mileage may vary.


--- ./include/asm-ia64/intel_intrin.h.orig	2006-01-25 17:40:12.468497883 -0800
+++ ./include/asm-ia64/intel_intrin.h	2006-01-25 21:04:41.921472582 -0800
@@ -122,7 +122,8 @@ __s64 _m64_popcnt(__s64 a);
 #define ia64_getreg		__getReg
 #define ia64_setreg		__setReg
 
-#define ia64_hint(x)
+#define ia64_hint		__hint
+#define ia64_hint_pause		0
 
 #define ia64_mux1_brcst	 0
 #define ia64_mux1_mix		 8

Re: [patch] fix ia64_hint definition for intel compiler intrinsic

[H. J. Lu]

On Wed, Jan 25, 2006 at 08:24:33PM -0800, Chen, Kenneth W wrote:
> Map ia64_hint() to internal intel compiler intrinsic.
> 
> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
> 
> ---
> Compile tested on selective files.  icc 9.0 appears to have
> memory clobber behavior for the hint@pause intrinsic similar
> to gcc with "memory" clobber modifier. Your mileage may vary.
> 
> 
> --- ./include/asm-ia64/intel_intrin.h.orig	2006-01-25 17:40:12.468497883 -0800
> +++ ./include/asm-ia64/intel_intrin.h	2006-01-25 21:04:41.921472582 -0800

include/asm-ia64/intel_intrin.h should just include <ia64intrin.h>.
Why not check out my patch:

http://marc.theaimsgroup.com/?l=linux-ia64&m\x113475932502202&w=2


H.J.

RE: [patch] fix ia64_hint definition for intel compiler intrinsic

[Luck, Tony]

> include/asm-ia64/intel_intrin.h should just include <ia64intrin.h>.
> Why not check out my patch:
> 
> http://marc.theaimsgroup.com/?l=linux-ia64&m\x113475932502202&w=2

There are two patches attached to that message, the first deletes
all contents from include/asm-ia64/intel_intrin.h.  The second puts
in the #include <ia64intrin.h> together with a bunch of Linux specific
defines including:

+#define ia64_hint(x)

So I'd need Ken's patch on top of yours to make cpu_relax() actually
do something, right?

The second patch also changed some sn2 specific code and didn't get
an ack.

Overall, it would be interesting to get the ia64 kernel building and
running on icc (if only to get the benefit of different warning/error
checking in an alternate compiler).

-Tony

RE: [patch] fix ia64_hint definition for intel compiler intrinsic

[Chen, Kenneth W]

Luck, Tony wrote on Thursday, January 26, 2006 10:55 AM
> There are two patches attached to that message, the first deletes
> all contents from include/asm-ia64/intel_intrin.h.  The second puts
> in the #include <ia64intrin.h> together with a bunch of Linux specific
> defines including:
> 
> +#define ia64_hint(x)
> 
> So I'd need Ken's patch on top of yours to make cpu_relax() actually
> do something, right?

I believe so.  My patch from yesterday maps kernel internal definition
of ia64_hint to icc intrinsic, which the standard intel icc header file
doesn't know anything about.  Regardless, we need that patch.

- Ken