From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: 'Adrian Bunk' <bunk@stusta.de>, Jes Sorensen <jes@sgi.com>
Cc: 'Keith Owens' <kaos@sgi.com>, "Luck, Tony" <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [2.6 patch] let IA64_GENERIC select more stuff
Date: Wed, 08 Feb 2006 22:24:51 +0000 [thread overview]
Message-ID: <200602082224.k18MOpg24612@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060208213825.GQ3524@stusta.de>
In-Reply-To: <20060207231713.GG3524@stusta.de>
Adrian Bunk wrote on Wednesday, February 08, 2006 1:38 PM
> > Not really, it helps a bit by selecting some things we know we need
> > for all GENERIC builds. True we can't make it bullet proof, but whats
> > there is better than removing it.
>
> Like the bug of allowing the illegal configuration NUMA=y, FLATMEM=y?
You can't even compile a kernel with that combination ...
Just about every arch except ia64 turns off ARCH_FLATMEM_ENABLE if NUMA=y.
ia64 can just do the same thing. Instead of mucking around with select,
fix the bug at its source. The real culprit is in mm/Kconfig, it shouldn't
enable ARCH_FLATMEM_ENABLE if NUMA=y.
Fix ARCH_FLATMEM_ENABLE dependency in ia64 arch.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
--- ./arch/ia64/Kconfig.orig 2006-02-08 14:57:40.597354431 -0800
+++ ./arch/ia64/Kconfig 2006-02-08 15:04:15.552427718 -0800
@@ -298,7 +298,8 @@ config ARCH_DISCONTIGMEM_ENABLE
See <file:Documentation/vm/numa> for more.
config ARCH_FLATMEM_ENABLE
- def_bool y
+ depends on !NUMA
+ def_bool y if !NUMA
config ARCH_SPARSEMEM_ENABLE
def_bool y
next prev parent reply other threads:[~2006-02-08 22:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 22:11 [2.6 patch] IA64_GENERIC shouldn't select other stuff Adrian Bunk
2006-02-07 22:37 ` Keith Owens
2006-02-07 22:43 ` Matthew Wilcox
2006-02-07 22:53 ` Adrian Bunk
2006-02-07 23:17 ` [2.6 patch] let IA64_GENERIC select more stuff Adrian Bunk
2006-02-08 0:52 ` Chen, Kenneth W
2006-02-08 1:19 ` Adrian Bunk
2006-02-08 1:40 ` Chen, Kenneth W
2006-02-08 2:08 ` Adrian Bunk
2006-02-08 2:17 ` Chen, Kenneth W
2006-02-08 2:43 ` Adrian Bunk
2006-02-08 2:48 ` Keith Owens
2006-02-08 2:54 ` Matthew Wilcox
2006-02-08 2:58 ` Chen, Kenneth W
2006-02-08 3:51 ` Adrian Bunk
2006-02-08 5:52 ` Chen, Kenneth W
2006-02-08 11:59 ` Adrian Bunk
2006-02-08 13:38 ` Jes Sorensen
2006-02-08 21:38 ` Adrian Bunk
2006-02-09 12:53 ` Jes Sorensen
2006-02-09 13:18 ` Matthew Wilcox
2006-02-09 13:26 ` Jes Sorensen
2006-02-09 14:16 ` Adrian Bunk
2006-02-09 15:19 ` Jes Sorensen
2006-02-08 18:35 ` Luck, Tony
2006-02-08 19:21 ` Alex Williamson
2006-02-08 19:24 ` Jes Sorensen
2006-02-08 19:48 ` Luck, Tony
2006-02-08 19:55 ` Chen, Kenneth W
2006-02-08 21:24 ` Matthew Wilcox
2006-02-08 21:36 ` Chen, Kenneth W
2006-02-08 22:24 ` Chen, Kenneth W [this message]
2006-02-08 22:49 ` Adrian Bunk
2006-02-08 22:35 ` Luck, Tony
2006-02-07 23:06 ` [2.6 patch] IA64_GENERIC shouldn't select other stuff Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602082224.k18MOpg24612@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=bunk@stusta.de \
--cc=jes@sgi.com \
--cc=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox