From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH -mm HOT-FIX] fix build on ia64 (modpost.c)
Date: Mon, 20 Feb 2006 19:25:00 +0000 [thread overview]
Message-ID: <20060220192500.GA17003@mars.ravnborg.org> (raw)
In-Reply-To: <20060220042615.5af1bddc.akpm@osdl.org>
>
> - This kernel won't compile on ia64 (and possibly other architectures)
> because the kbuild tree is using Elf_Rela in scripts/mod/modpost.c. Is OK
> on x86, x86_64 and powerpc. Sam might send a hotfix?
Attached is a real hot-fix. It disables the new check entirely.
I like to learn:
1) Why IA64 is missing Elf64_Rela. Can someone drop me a copy of elf.h -
and include gcc + binutils version in the mail - thanks.
2) I also like to know if other architectures broke - so I can figure
out how to fix this.
I have tested this on X86_64/amd64 (gentoo based) only.
Sam
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 844f84b..b87070a 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -451,6 +451,7 @@ static char *get_modinfo(void *modinfo,
return NULL;
}
+#if 0
/**
* Find symbol based on relocation record info.
* In some cases the symbol supplied is a valid symbol so
@@ -616,7 +617,12 @@ static void check_sec_ref(struct module
}
}
}
-
+#endif
+static void check_sec_ref(struct module *mod, const char *modname,
+ struct elf_info *elf,
+ int section(const char*),
+ int section_ref_ok(const char *))
+{}
/**
* Functions used only during module init is marked __init and is stored in
* a .init.text section. Likewise data is marked __initdata and stored in
next parent reply other threads:[~2006-02-20 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060220042615.5af1bddc.akpm@osdl.org>
2006-02-20 19:25 ` Sam Ravnborg [this message]
2006-02-20 21:37 ` [PATCH -mm HOT-FIX] fix build on ia64 (modpost.c) Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060220192500.GA17003@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox