[PATCH -mm HOT-FIX] fix build on ia64 (modpost.c)

[PATCH -mm HOT-FIX] fix build on ia64 (modpost.c)

[Sam Ravnborg]

> 
> - This kernel won't compile on ia64 (and possibly other architectures)
>   because the kbuild tree is using Elf_Rela in scripts/mod/modpost.c.  Is OK
>   on x86, x86_64 and powerpc.  Sam might send a hotfix?

Attached is a real hot-fix. It disables the new check entirely.

I like to learn:
1) Why IA64 is missing Elf64_Rela. Can someone drop me a copy of elf.h -
and include gcc + binutils version in the mail - thanks.

2) I also like to know if other architectures broke - so I can figure
out how to fix this.

I have tested this on X86_64/amd64 (gentoo based) only.

	Sam

	
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 844f84b..b87070a 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -451,6 +451,7 @@ static char *get_modinfo(void *modinfo, 
 	return NULL;
 }
 
+#if 0
 /**
  * Find symbol based on relocation record info.
  * In some cases the symbol supplied is a valid symbol so
@@ -616,7 +617,12 @@ static void check_sec_ref(struct module 
 		}
 	}
 }
-
+#endif
+static void check_sec_ref(struct module *mod, const char *modname,
+			  struct elf_info *elf,
+			  int section(const char*),
+			  int section_ref_ok(const char *))
+{}
 /**
  * Functions used only during module init is marked __init and is stored in
  * a .init.text section. Likewise data is marked __initdata and stored in

Re: [PATCH -mm HOT-FIX] fix build on ia64 (modpost.c)

[Andrew Morton]

Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > 
> > - This kernel won't compile on ia64 (and possibly other architectures)
> >   because the kbuild tree is using Elf_Rela in scripts/mod/modpost.c.  Is OK
> >   on x86, x86_64 and powerpc.  Sam might send a hotfix?
> 
> Attached is a real hot-fix. It disables the new check entirely.

Well that bit compiles.

> I like to learn:
> 1) Why IA64 is missing Elf64_Rela. Can someone drop me a copy of elf.h -
> and include gcc + binutils version in the mail - thanks.

This thing's running RHAS2.1 which I think dates from before the invention
of the transistor.  Running home-made gcc-3.3.2 and binutils-2.14.90.0.6-1.

I'll send along the three elf.h's under /usr/include.

> 2) I also like to know if other architectures broke - so I can figure
> out how to fix this.

Dunno yet - I didn't do the normal batch of cross-compiles due to spending
six hours chasing down new bugs.

> I have tested this on X86_64/amd64 (gentoo based) only.

That fixes the modpost.c compile, but the new futex stuff fails because
ia64 doesn't implement ptr_to_compat().  In fact only three architectures
appear to do so.