From: Christoph Hellwig <hch@infradead.org>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Christoph Lameter <clameter@sgi.com>, Jes Sorensen <jes@sgi.com>
Subject: Re: [PATCH] Add SA_PERCPU_IRQ flag support
Date: Fri, 17 Mar 2006 02:09:42 +0000 [thread overview]
Message-ID: <20060317020942.GA20227@infradead.org> (raw)
In-Reply-To: <20060317003114.GA1735@sgi.com>
On Thu, Mar 16, 2006 at 06:31:14PM -0600, Dimitri Sivanich wrote:
> The generic request_irq/setup_irq code should support the SA_PERCPU_IRQ flag.
>
> Not sure why it was left out, but this patch adds that support.
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
>
> Index: linux/kernel/irq/manage.c
> =================================> --- linux.orig/kernel/irq/manage.c 2006-03-16 14:05:27.957927445 -0600
> +++ linux/kernel/irq/manage.c 2006-03-16 14:06:02.283661867 -0600
> @@ -201,6 +201,9 @@ int setup_irq(unsigned int irq, struct i
> * The following block of code has to be executed atomically
> */
> spin_lock_irqsave(&desc->lock,flags);
> + if (new->flags & SA_PERCPU_IRQ) {
> + desc->status |= IRQ_PER_CPU;
> + }
looks good, although the braces aren't really needed for single-line
conditionals.
next prev parent reply other threads:[~2006-03-17 2:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 0:31 [PATCH] Add SA_PERCPU_IRQ flag support Dimitri Sivanich
2006-03-17 2:09 ` Christoph Hellwig [this message]
2006-03-17 23:26 ` Andrew Morton
2006-03-18 9:49 ` Andrew Morton
2006-03-20 14:17 ` Dimitri Sivanich
2006-03-20 14:22 ` Matthew Wilcox
2006-03-20 14:25 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317020942.GA20227@infradead.org \
--to=hch@infradead.org \
--cc=clameter@sgi.com \
--cc=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox