* [PATCH] [IA64] kdump: kdump_disable_iosapic needs CONFIG_IOSAPIC
@ 2006-09-15 1:44 Horms
2006-09-15 1:48 ` [PATCH] [IA64] kdump: kdump_disable_iosapic needs CONFIG_KEXEC Horms
0 siblings, 1 reply; 2+ messages in thread
From: Horms @ 2006-09-15 1:44 UTC (permalink / raw)
To: linux-ia64
Hi Nanhai,
here is a minor patch against your lastest ia64 kexec patch.
kdump_disable_iosapic() doesn't exist without CONFIG_IOSAPIC,
calling it needs to be gaurded by a corresponding #ifdef
Signed-Off-By: Simon Horman <horms@verge.net.au>
diff --git a/arch/ia64/kernel/crash.c b/arch/ia64/kernel/crash.c
index aa63c47..e15e15d 100644
--- a/arch/ia64/kernel/crash.c
+++ b/arch/ia64/kernel/crash.c
@@ -42,7 +42,9 @@ size_t copy_oldmem_page(unsigned long pf
static void device_shootdown(void)
{
+#ifdef CONFIG_IOSAPIC
kdump_disable_iosapic();
+#endif
#ifdef CONFIG_IA64_HP_ZX1
ioc_iova_disable();
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] [IA64] kdump: kdump_disable_iosapic needs CONFIG_KEXEC
2006-09-15 1:44 [PATCH] [IA64] kdump: kdump_disable_iosapic needs CONFIG_IOSAPIC Horms
@ 2006-09-15 1:48 ` Horms
0 siblings, 0 replies; 2+ messages in thread
From: Horms @ 2006-09-15 1:48 UTC (permalink / raw)
To: linux-ia64
Hi Nanhai,
Currently kdump_disable_iosapic is gaurded by CONFIG_CRASH_DUMP,
however it is run buy the crashing kernel, not the crash kernel,
and thus needs to be present for CONFIG_KEXEC, not CONFIG_CRASH_DUMP.
Signed-Off-By: Simon Horman <horms@verge.net.au>
diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c
index 9e9367a..2f58502 100644
--- a/arch/ia64/kernel/iosapic.c
+++ b/arch/ia64/kernel/iosapic.c
@@ -288,7 +288,7 @@ nop (unsigned int irq)
/* do nothing... */
}
-#ifdef CONFIG_CRASH_DUMP
+#ifdef CONFIG_KEXEC
void
kdump_disable_iosapic(void)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-15 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-15 1:44 [PATCH] [IA64] kdump: kdump_disable_iosapic needs CONFIG_IOSAPIC Horms
2006-09-15 1:48 ` [PATCH] [IA64] kdump: kdump_disable_iosapic needs CONFIG_KEXEC Horms
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox