From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] Add support for type argument in PAL_GET_PSTATE
Date: Wed, 01 Nov 2006 18:35:01 +0000 [thread overview]
Message-ID: <20061101103500.A16140@unix-os.sc.intel.com> (raw)
PAL_GET_PSTATE accepts a type argument to return different kinds of
frequency information.
Refer: Intel Itanium®Architecture Software Developer's Manual -
Volume 2: System Architecture, Revision 2.2
(http://developer.intel.com/design/itanium/manuals/245318.htm)
Add the support for type argument and use Instantaneous frequency
in the acpi driver.
Also fix a bug, where in return value of PAL_GET_PSTATE was getting compared
with 'control' bits instead of 'status' bits.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
diff -purN linux-2.6.18/arch/ia64/kernel/cpufreq/acpi-cpufreq.c linux-2.6.18-new/arch/ia64/kernel/cpufreq/acpi-cpufreq.c
--- linux-2.6.18/arch/ia64/kernel/cpufreq/acpi-cpufreq.c 2006-09-19 20:42:06.000000000 -0700
+++ linux-2.6.18-new/arch/ia64/kernel/cpufreq/acpi-cpufreq.c 2006-10-10 09:58:32.000000000 -0700
@@ -68,7 +68,8 @@ processor_get_pstate (
dprintk("processor_get_pstate\n");
- retval = ia64_pal_get_pstate(&pstate_index);
+ retval = ia64_pal_get_pstate(&pstate_index,
+ PAL_GET_PSTATE_TYPE_INSTANT);
*value = (u32) pstate_index;
if (retval)
@@ -91,7 +92,7 @@ extract_clock (
dprintk("extract_clock\n");
for (i = 0; i < data->acpi_data.state_count; i++) {
- if (value >= data->acpi_data.states[i].control)
+ if (value = data->acpi_data.states[i].status)
return data->acpi_data.states[i].core_frequency;
}
return data->acpi_data.states[i-1].core_frequency;
@@ -117,11 +118,7 @@ processor_get_freq (
goto migrate_end;
}
- /*
- * processor_get_pstate gets the average frequency since the
- * last get. So, do two PAL_get_freq()...
- */
- ret = processor_get_pstate(&value);
+ /* processor_get_pstate gets the instantaneous frequency */
ret = processor_get_pstate(&value);
if (ret) {
diff -purN linux-2.6.18/include/asm-ia64/pal.h linux-2.6.18-new/include/asm-ia64/pal.h
--- linux-2.6.18/include/asm-ia64/pal.h 2006-09-19 20:42:06.000000000 -0700
+++ linux-2.6.18-new/include/asm-ia64/pal.h 2006-10-10 09:59:47.000000000 -0700
@@ -79,6 +79,11 @@
#define PAL_GET_PSTATE 262 /* get the current P-state */
#define PAL_SET_PSTATE 263 /* set the P-state */
+#define PAL_GET_PSTATE_TYPE_LASTSET (0)
+#define PAL_GET_PSTATE_TYPE_AVGANDRESET (1)
+#define PAL_GET_PSTATE_TYPE_AVGNORESET (2)
+#define PAL_GET_PSTATE_TYPE_INSTANT (3)
+
#ifndef __ASSEMBLY__
#include <linux/types.h>
@@ -1116,10 +1121,10 @@ ia64_pal_halt_info (pal_power_mgmt_info_
/* Get the current P-state information */
static inline s64
-ia64_pal_get_pstate (u64 *pstate_index)
+ia64_pal_get_pstate (u64 *pstate_index, unsigned long type)
{
struct ia64_pal_retval iprv;
- PAL_CALL_STK(iprv, PAL_GET_PSTATE, 0, 0, 0);
+ PAL_CALL_STK(iprv, PAL_GET_PSTATE, type, 0, 0);
*pstate_index = iprv.v0;
return iprv.status;
}
next reply other threads:[~2006-11-01 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 18:35 Venkatesh Pallipadi [this message]
2006-12-01 16:36 ` [PATCH] Add support for type argument in PAL_GET_PSTATE Jes Sorensen
2006-12-01 16:38 ` Jes Sorensen
2006-12-01 23:28 ` Venkatesh Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101103500.A16140@unix-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox