public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Add support for type argument in PAL_GET_PSTATE
Date: Fri, 01 Dec 2006 16:36:19 +0000	[thread overview]
Message-ID: <yq0bqmnvaik.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <20061101103500.A16140@unix-os.sc.intel.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1252", Size: 985 bytes --]

>>>>> "Venkatesh" = Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> writes:

Venkatesh> PAL_GET_PSTATE accepts a type argument to return different
Venkatesh> kinds of frequency information.  Refer: Intel
Venkatesh> Itanium®Architecture Software Developer's Manual -
Venkatesh> Volume 2: System Architecture, Revision 2.2
Venkatesh> (http://developer.intel.com/design/itanium/manuals/245318.htm)

....

Venkatesh> @@ -79,6 +79,11 @@
Venkatesh>  #define PAL_GET_PSTATE		262	/* get the current P-state */
Venkatesh>  #define PAL_SET_PSTATE		263	/* set the P-state */
Venkatesh>  
Venkatesh> +#define PAL_GET_PSTATE_TYPE_LASTSET	(0)
Venkatesh> +#define PAL_GET_PSTATE_TYPE_AVGANDRESET	(1)
Venkatesh> +#define PAL_GET_PSTATE_TYPE_AVGNORESET	(2)
Venkatesh> +#define PAL_GET_PSTATE_TYPE_INSTANT	(3)
Venkatesh> +

Hi Venkatesh,

Please respect the previous formatting of the file and not add
pointless parenthesises around the constants like that.

Cheers,
Jes

  reply	other threads:[~2006-12-01 16:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 18:35 [PATCH] Add support for type argument in PAL_GET_PSTATE Venkatesh Pallipadi
2006-12-01 16:36 ` Jes Sorensen [this message]
2006-12-01 16:38 ` Jes Sorensen
2006-12-01 23:28 ` Venkatesh Pallipadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq0bqmnvaik.fsf@jaguar.mkp.net \
    --to=jes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox