From: Bernhard Walle <bwalle@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0)
Date: Thu, 22 Mar 2007 22:45:34 +0000 [thread overview]
Message-ID: <20070322224534.GA12791@sykes.suse.de> (raw)
In-Reply-To: <1174598601.10840.231.camel@localhost.localdomain>
Hello,
* Thomas Gleixner <tglx@linutronix.de> [2007-03-22 22:23]:
>
> > Also, the code presently passes the magic IRQ number into the generic IRQ
> > code. I wonder if we'd get a more pleasing result if we were to make the
> > generic IRQ code call _out_ to the architecture:
>
> > Then, ia64 can implement arch_is_irqpoll_irq() and it can do whatever it
> > wants in there.
> >
> > The __attribute__((weak)) thing adds a little bit of overhead, but I don't
> > think this is a fastpath?
>
> Well, depends what you consider a fastpath. When noirqdebug = 0, it is
> called on every interrupt.
I think that function is only called if irqfixup = 2, because if the
first condition in the expression is wrong, the evaluation of the
expression is aborted in C.
Regards,
Bernhard
next prev parent reply other threads:[~2007-03-22 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 14:59 [PATCH] Fix irqpoll on IA64 (timer interrupt != 0) Bernhard Walle
2007-03-22 21:09 ` Andrew Morton
2007-03-22 21:23 ` Thomas Gleixner
2007-03-22 22:02 ` Andrew Morton
2007-03-22 22:45 ` Bernhard Walle [this message]
2007-03-22 23:04 ` Bernhard Walle
2007-03-22 23:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322224534.GA12791@sykes.suse.de \
--to=bwalle@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox