[patch 0/5] ia64 memory attribute fixes

[patch 0/5] ia64 memory attribute fixes

[Bjorn Helgaas]

This series fixes a few memory mapping issues on ia64.  Outline:

  1  rename ioremap variables to match i386 (no functional change)
  2  use page table mappings in ioremap to avoid unsupported attributes
  3  allow WB mmap of /sys/.../legacy_mem
  4  fail mmaps that span areas with incompatible attributes
  5  update documentation & add tests

These are independent except that 2 depends on 1.

Re: [patch 0/5] ia64 memory attribute fixes

[Bjorn Helgaas]

On Wednesday 21 March 2007 16:16, Bjorn Helgaas wrote:
> This series fixes a few memory mapping issues on ia64.  Outline:
> 
>   1  rename ioremap variables to match i386 (no functional change)
>   2  use page table mappings in ioremap to avoid unsupported attributes
>   3  allow WB mmap of /sys/.../legacy_mem
>   4  fail mmaps that span areas with incompatible attributes
>   5  update documentation & add tests
> 
> These are independent except that 2 depends on 1.

Andrew, I should have copied you on this series so you could put
it in -mm (assuming you think it looks reasonable).

Tony plans to apply the series after 2.6.21 pops, but it'd be
nice to get a little runtime before then.

Should I forward the series to you, or do you have copies?

Bjorn

Re: [patch 0/5] ia64 memory attribute fixes

[Andrew Morton]

On Thu, 29 Mar 2007 08:54:04 -0600 Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

> On Wednesday 21 March 2007 16:16, Bjorn Helgaas wrote:
> > This series fixes a few memory mapping issues on ia64.  Outline:
> > 
> >   1  rename ioremap variables to match i386 (no functional change)
> >   2  use page table mappings in ioremap to avoid unsupported attributes
> >   3  allow WB mmap of /sys/.../legacy_mem
> >   4  fail mmaps that span areas with incompatible attributes
> >   5  update documentation & add tests
> > 
> > These are independent except that 2 depends on 1.
> 
> Andrew, I should have copied you on this series so you could put
> it in -mm (assuming you think it looks reasonable).
> 
> Tony plans to apply the series after 2.6.21 pops, but it'd be
> nice to get a little runtime before then.
> 
> Should I forward the series to you, or do you have copies?
> 

My linux-ia64 feed seems to have broken, so a resend would be appreciated,
thanks.

RE: [patch 0/5] ia64 memory attribute fixes

[Luck, Tony]

> My linux-ia64 feed seems to have broken, so a resend would be appreciated,
> thanks.

I'll stack these patches into my "test" tree and push it later
today ... save the repost and some of your time.

-Tony

RE: [patch 0/5] ia64 memory attribute fixes

[Luck, Tony]

Found a small problem.  With this patch in place I get
a complaint while booting on an Intel tiger:

Trying to vfree() bad address (a00000020001b000)
BUG: at vm/vmalloc.c:323 __vunmap()

The stack trace points back to drivers/firmware/dmi_scan.c
in dmi_table()

	buf = dmi_ioremap(base, len);
		...
	dmi_iounmap(buf, len);

Before applying your patch we have base=0x7fefb000 len=0xfbc
and the return value is 0xc00000007fefb000

After your patch, we get buf = 0xa00000020001b000

-Tony

Re: [patch 0/5] ia64 memory attribute fixes

[Bjorn Helgaas]

On Thursday 29 March 2007 17:54, Luck, Tony wrote:
> Found a small problem.  With this patch in place I get
> a complaint while booting on an Intel tiger:
> 
> Trying to vfree() bad address (a00000020001b000)
> BUG: at vm/vmalloc.c:323 __vunmap()

Oops, I forgot to page-align the address before passing it to
vunmap().  I'll post an updated patch with the fix.