public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 3/5] ia64: allow WB /sys/.../legacy_mem mmaps
@ 2007-03-21 22:21 Bjorn Helgaas
  2007-03-30 16:34 ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2007-03-21 22:21 UTC (permalink / raw)
  To: linux-ia64

Allow cacheable mmaps of legacy_mem if WB access is supported for the region.
The "legacy_mem" file often contains a shadow option ROM, and some versions of
X depend on this.

Tim Yamin <plasm@roo.me.uk> reported that this change fixes X on a Dell
PowerEdge 3250.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Index: work-mm10/arch/ia64/pci/pci.c
=================================--- work-mm10.orig/arch/ia64/pci/pci.c	2007-03-21 14:13:22.000000000 -0700
+++ work-mm10/arch/ia64/pci/pci.c	2007-03-21 14:15:01.000000000 -0700
@@ -656,8 +656,6 @@
 		return -EINVAL;
 	prot = phys_mem_access_prot(NULL, vma->vm_pgoff, size,
 				    vma->vm_page_prot);
-	if (pgprot_val(prot) != pgprot_val(pgprot_noncached(vma->vm_page_prot)))
-		return -EINVAL;
 
 	addr = pci_get_legacy_mem(bus);
 	if (IS_ERR(addr))

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [patch 3/5] ia64: allow WB /sys/.../legacy_mem mmaps
  2007-03-21 22:21 [patch 3/5] ia64: allow WB /sys/.../legacy_mem mmaps Bjorn Helgaas
@ 2007-03-30 16:34 ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2007-03-30 16:34 UTC (permalink / raw)
  To: linux-ia64

Allow cacheable mmaps of legacy_mem if WB access is supported for the region.
The "legacy_mem" file often contains a shadow option ROM, and some versions of
X depend on this.

Tim Yamin <plasm@roo.me.uk> reported that this change fixes X on a Dell
PowerEdge 3250.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Index: work-mm10/arch/ia64/pci/pci.c
=================================--- work-mm10.orig/arch/ia64/pci/pci.c	2007-03-21 14:13:22.000000000 -0700
+++ work-mm10/arch/ia64/pci/pci.c	2007-03-21 14:15:01.000000000 -0700
@@ -656,8 +656,6 @@
 		return -EINVAL;
 	prot = phys_mem_access_prot(NULL, vma->vm_pgoff, size,
 				    vma->vm_page_prot);
-	if (pgprot_val(prot) != pgprot_val(pgprot_noncached(vma->vm_page_prot)))
-		return -EINVAL;
 
 	addr = pci_get_legacy_mem(bus);
 	if (IS_ERR(addr))

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-30 16:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-21 22:21 [patch 3/5] ia64: allow WB /sys/.../legacy_mem mmaps Bjorn Helgaas
2007-03-30 16:34 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox