Re: [GIT PATCH] ACPI patches for 2.6.23-rc1

[Adrian Bunk <bunk@stusta.de>]

On Fri, Jul 27, 2007 at 06:25:12PM +0200, Thomas Renninger wrote:
> On Fri, 2007-07-27 at 08:26 +0200, Jan Dittmer wrote:
> > Len Brown wrote:
> > > Hi Linus,
> > > 
> > > please pull from: 
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release
> > 
> > This seems to break ia64 defconfig:
> > 
> >    Building modules, stage 2.
> >    MODPOST 157 modules
> > FATAL: drivers/acpi/button: sizeof(struct acpi_device_id)  is not a modulo of the size of section __mod_acpi_device_table\x144.
> > Fix definition of struct acpi_device_id in mod_devicetable.h
> > make[2]: *** [__modpost] Error 1
> > make[1]: *** [modules] Error 2
> > make: *** [_all] Error 2
> > 
> > gcc 3.3.6, binutils 2.15.94
> > 
> > http://l4x.org/k/?d2569
> 
> This is strange, I just compiled on a IA64 with button as module
> (defconfig), but with gcc version 4.1.2, all is fine.
> Anyone an idea how to run into that?

I don't have an idea how this happens, but it sounds like an alignment 
issue:

sizeof(struct acpi_device_id) 
"struct acpi_device_id button_device_ids[]" contains 6 elements
144 = 6 * 24 = 6 * (3 * 8)

So it seems on ia64 with gcc 3.3.6 there's some 8 byte alignment of the 
array members?

Sam and the ia64 maintainers Cc'ed - they might know better what's going 
on here.

> I won't be able to detailed debug this before Monday, but be sure I will
> do so then.
> 
> Thanks,
> 
>     Thomas

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed