From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH]forbid ptrace changes psr.ri to 3
Date: Fri, 17 Aug 2007 18:40:03 +0000 [thread overview]
Message-ID: <200708171240.03836.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1187244999.30462.6.camel@sli10-conroe.sh.intel.com>
On Friday 17 August 2007 11:21:14 am Luck, Tony wrote:
> > IA64_PSR_RI is in IPSR_MASK, apparently by intent.
> > If you want to change the behavior, you should simply change that mask.
>
> psr.ri is more complex because it is two bits where not all of the
> possible bit settings are defined. We definitely want to allow ptrace
> to set psr.ri (how else can we single step through instructions in
> a bundle?) But we should only allow psr.ri to be set to 0, 1, or 2.
This confused me, too, because the changelog and comments say
"PSR.ri bits 3 are reserved" and "psr.ri bits 11 are reserved".
Something like "PSR.ri value 3 is reserved" would have made
the intent more clear.
Bjorn
next prev parent reply other threads:[~2007-08-17 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 6:16 [PATCH]forbid ptrace changes psr.ri to 3 Shaohua Li
2007-08-17 6:01 ` Roland McGrath
2007-08-17 17:21 ` Luck, Tony
2007-08-17 18:40 ` Bjorn Helgaas [this message]
2007-08-17 18:44 ` Luck, Tony
2007-08-17 18:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708171240.03836.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox