* iounmap after ioremap in arch/ia64/sn/pci/pcibr/pcibr_provider.c
@ 2007-11-03 23:43 Roel Kluin
2007-11-05 2:15 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2007-11-03 23:43 UTC (permalink / raw)
To: linux-ia64
A better discription, maybe?
--
iounmap after ioremap
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/ia64/sn/pci/pcibr/pcibr_provider.c b/arch/ia64/sn/pci/pcibr/pcibr_provider.c
index ab3eaf8..00d1b85 100644
--- a/arch/ia64/sn/pci/pcibr/pcibr_provider.c
+++ b/arch/ia64/sn/pci/pcibr/pcibr_provider.c
@@ -186,6 +186,7 @@ pcibr_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
if (!soft->pbi_int_ate_resource.ate) {
kfree(soft);
+ iounmap(soft->pbi_buscommon.bs_base);
return NULL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: iounmap after ioremap in arch/ia64/sn/pci/pcibr/pcibr_provider.c
2007-11-03 23:43 iounmap after ioremap in arch/ia64/sn/pci/pcibr/pcibr_provider.c Roel Kluin
@ 2007-11-05 2:15 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2007-11-05 2:15 UTC (permalink / raw)
To: linux-ia64
On Sun, Nov 04, 2007 at 12:43:42AM +0100, Roel Kluin wrote:
> A better discription, maybe?
> --
> iounmap after ioremap
Again, this looks correct to me, so long as calling iounmap() actually
reverses ioremap() in this case.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/ia64/sn/pci/pcibr/pcibr_provider.c b/arch/ia64/sn/pci/pcibr/pcibr_provider.c
> index ab3eaf8..00d1b85 100644
> --- a/arch/ia64/sn/pci/pcibr/pcibr_provider.c
> +++ b/arch/ia64/sn/pci/pcibr/pcibr_provider.c
> @@ -186,6 +186,7 @@ pcibr_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
>
> if (!soft->pbi_int_ate_resource.ate) {
> kfree(soft);
> + iounmap(soft->pbi_buscommon.bs_base);
> return NULL;
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-05 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-03 23:43 iounmap after ioremap in arch/ia64/sn/pci/pcibr/pcibr_provider.c Roel Kluin
2007-11-05 2:15 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox