From: Simon Horman <horms@verge.net.au>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c
Date: Mon, 05 Nov 2007 09:34:25 +0000 [thread overview]
Message-ID: <20071105093423.GA25553@verge.net.au> (raw)
In-Reply-To: <472DA917.9050000@tiscali.nl>
On Mon, Nov 05, 2007 at 10:10:13AM +0100, Roel Kluin wrote:
> Simon Horman wrote:
> > On Sun, Nov 04, 2007 at 12:12:23PM +0100, Roel Kluin wrote:
> >> Do iounmap if tioce_kern_init fails
> >
> > This is covered by a subsequent patch, right?
>
> aparently it should, what am I missing?
Nothing, I was just confirming that it is duplicated elsewhere :-)
> >> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> >> ---
> >> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> >> index cee9379..128ed07 100644
> >> --- a/arch/ia64/sn/pci/tioce_provider.c
> >> +++ b/arch/ia64/sn/pci/tioce_provider.c
> >> @@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
> >>
> >> tioce_kern = tioce_kern_init(tioce_common);
> >> if (tioce_kern = NULL) {
> >> + iounmap(tioce_common->ce_pcibus.bs_base);
> >> kfree(tioce_common);
> >> return NULL;
> >> }
>
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
prev parent reply other threads:[~2007-11-05 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 11:12 [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c Roel Kluin
2007-11-05 2:17 ` Simon Horman
2007-11-05 9:10 ` Roel Kluin
2007-11-05 9:34 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105093423.GA25553@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox