From: Stephane Eranian <eranian@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [perfmon] sysctl table check failed ... Writable sysctl directory
Date: Tue, 06 Nov 2007 20:18:11 +0000 [thread overview]
Message-ID: <20071106201811.GA13972@frankl.hpl.hp.com> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A02E21EDD@scsmsx411.amr.corp.intel.com>
Tony,
Don't need 755, please apply your patch.
Thanks.
On Tue, Nov 06, 2007 at 11:59:55AM -0800, Luck, Tony wrote:
> Stephane,
>
> For a couple of weeks now the kernel has been complaining about
> a couple of "Writable sysctl directories". When I pulled from
> Linus latest git tree today, the complaint got louder with an
> added stack trace ... pointing at pfm_init().
>
> This patch fixes the complaint. Did you need mode 0755 for
> some reason, or should I just apply this?
>
> -Tony
>
> ---
>
> diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c
> index 59169bf..73e7c2e 100644
> --- a/arch/ia64/kernel/perfmon.c
> +++ b/arch/ia64/kernel/perfmon.c
> @@ -558,7 +558,7 @@ static ctl_table pfm_sysctl_dir[] = {
> {
> .ctl_name = CTL_UNNUMBERED,
> .procname = "perfmon",
> - .mode = 0755,
> + .mode = 0555,
> .child = pfm_ctl_table,
> },
> {}
> @@ -567,7 +567,7 @@ static ctl_table pfm_sysctl_root[] = {
> {
> .ctl_name = CTL_KERN,
> .procname = "kernel",
> - .mode = 0755,
> + .mode = 0555,
> .child = pfm_sysctl_dir,
> },
> {}
>
> _______________________________________________
> perfmon mailing list
> perfmon@linux.hpl.hp.com
> http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/
--
-Stephane
prev parent reply other threads:[~2007-11-06 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 19:59 sysctl table check failed ... Writable sysctl directory Luck, Tony
2007-11-06 20:18 ` Stephane Eranian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106201811.GA13972@frankl.hpl.hp.com \
--to=eranian@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox