* sysctl table check failed ... Writable sysctl directory
@ 2007-11-06 19:59 Luck, Tony
2007-11-06 20:18 ` [perfmon] " Stephane Eranian
0 siblings, 1 reply; 2+ messages in thread
From: Luck, Tony @ 2007-11-06 19:59 UTC (permalink / raw)
To: linux-ia64
Stephane,
For a couple of weeks now the kernel has been complaining about
a couple of "Writable sysctl directories". When I pulled from
Linus latest git tree today, the complaint got louder with an
added stack trace ... pointing at pfm_init().
This patch fixes the complaint. Did you need mode 0755 for
some reason, or should I just apply this?
-Tony
---
diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c
index 59169bf..73e7c2e 100644
--- a/arch/ia64/kernel/perfmon.c
+++ b/arch/ia64/kernel/perfmon.c
@@ -558,7 +558,7 @@ static ctl_table pfm_sysctl_dir[] = {
{
.ctl_name = CTL_UNNUMBERED,
.procname = "perfmon",
- .mode = 0755,
+ .mode = 0555,
.child = pfm_ctl_table,
},
{}
@@ -567,7 +567,7 @@ static ctl_table pfm_sysctl_root[] = {
{
.ctl_name = CTL_KERN,
.procname = "kernel",
- .mode = 0755,
+ .mode = 0555,
.child = pfm_sysctl_dir,
},
{}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [perfmon] sysctl table check failed ... Writable sysctl directory
2007-11-06 19:59 sysctl table check failed ... Writable sysctl directory Luck, Tony
@ 2007-11-06 20:18 ` Stephane Eranian
0 siblings, 0 replies; 2+ messages in thread
From: Stephane Eranian @ 2007-11-06 20:18 UTC (permalink / raw)
To: linux-ia64
Tony,
Don't need 755, please apply your patch.
Thanks.
On Tue, Nov 06, 2007 at 11:59:55AM -0800, Luck, Tony wrote:
> Stephane,
>
> For a couple of weeks now the kernel has been complaining about
> a couple of "Writable sysctl directories". When I pulled from
> Linus latest git tree today, the complaint got louder with an
> added stack trace ... pointing at pfm_init().
>
> This patch fixes the complaint. Did you need mode 0755 for
> some reason, or should I just apply this?
>
> -Tony
>
> ---
>
> diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c
> index 59169bf..73e7c2e 100644
> --- a/arch/ia64/kernel/perfmon.c
> +++ b/arch/ia64/kernel/perfmon.c
> @@ -558,7 +558,7 @@ static ctl_table pfm_sysctl_dir[] = {
> {
> .ctl_name = CTL_UNNUMBERED,
> .procname = "perfmon",
> - .mode = 0755,
> + .mode = 0555,
> .child = pfm_ctl_table,
> },
> {}
> @@ -567,7 +567,7 @@ static ctl_table pfm_sysctl_root[] = {
> {
> .ctl_name = CTL_KERN,
> .procname = "kernel",
> - .mode = 0755,
> + .mode = 0555,
> .child = pfm_sysctl_dir,
> },
> {}
>
> _______________________________________________
> perfmon mailing list
> perfmon@linux.hpl.hp.com
> http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/
--
-Stephane
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-06 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-06 19:59 sysctl table check failed ... Writable sysctl directory Luck, Tony
2007-11-06 20:18 ` [perfmon] " Stephane Eranian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox