From: Simon Horman <horms@verge.net.au>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Jes Sorensen <jes@sgi.com>,
Tony Luck <tony.luck@intel.com>,
linux-altix@sgi.com, linux-ia64@vger.kernel.org
Subject: Re: [PATCH 01/59] arch/ia64: Add missing "space"
Date: Tue, 20 Nov 2007 07:41:33 +0000 [thread overview]
Message-ID: <20071120074132.GA3402@verge.net.au> (raw)
In-Reply-To: <1195542565.4675.104.camel@localhost>
On Mon, Nov 19, 2007 at 11:09:25PM -0800, Joe Perches wrote:
> On Tue, 2007-11-20 at 15:54 +0900, Simon Horman wrote:
> > Is it really neccessary for this fragment to create a line that
> > is greater than 80 characters long? Persumably the entire reason
> > that the printk line was split in the first place was to avoid
> > a long line.
>
> No. Many other lines in that source file are > 80 char.
That may be so, but surely adding another one makes
things slightly worse.
> My initial preference was to reformat the indented lines to the
> printk open parenthesis, but the minimal change seemed better.
>
> cheers, Joe
--
Horms
prev parent reply other threads:[~2007-11-20 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1195523331-15303-1-git-send-email-joe@perches.com>
2007-11-20 1:47 ` [PATCH 01/59] arch/ia64: Add missing "space" Joe Perches
2007-11-20 6:54 ` Simon Horman
2007-11-20 7:09 ` Joe Perches
2007-11-20 7:41 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120074132.GA3402@verge.net.au \
--to=horms@verge.net.au \
--cc=jes@sgi.com \
--cc=joe@perches.com \
--cc=linux-altix@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox