From: Simon Horman <horms@verge.net.au>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Jes Sorensen <jes@sgi.com>,
Tony Luck <tony.luck@intel.com>,
linux-altix@sgi.com, linux-ia64@vger.kernel.org
Subject: Re: [PATCH 01/59] arch/ia64: Add missing "space"
Date: Tue, 20 Nov 2007 06:54:33 +0000 [thread overview]
Message-ID: <20071120065431.GC10490@verge.net.au> (raw)
In-Reply-To: <ee1678e1bc8b80b7ae420059fffc7241486ea91a.1195454434.git.joe@perches.com>
[snip]
> diff --git a/arch/ia64/kernel/kprobes.c b/arch/ia64/kernel/kprobes.c
> index 5fd65d8..90518e4 100644
> --- a/arch/ia64/kernel/kprobes.c
> +++ b/arch/ia64/kernel/kprobes.c
> @@ -182,8 +182,8 @@ static int __kprobes unsupported_inst(uint template, uint slot,
> qp = kprobe_inst & 0x3f;
> if (is_cmp_ctype_unc_inst(template, slot, major_opcode, kprobe_inst)) {
> if (slot = 1 && qp) {
> - printk(KERN_WARNING "Kprobes on cmp unc"
> - "instruction on slot 1 at <0x%lx>"
> + printk(KERN_WARNING "Kprobes on cmp unc "
> + "instruction on slot 1 at <0x%lx> "
> "is not supported\n", addr);
> return -EINVAL;
>
> @@ -221,8 +221,8 @@ static int __kprobes unsupported_inst(uint template, uint slot,
> * bit 12 to be equal to 1
> */
> if (slot = 1 && qp) {
> - printk(KERN_WARNING "Kprobes on test bit"
> - "instruction on slot at <0x%lx>"
> + printk(KERN_WARNING "Kprobes on test bit "
> + "instruction on slot at <0x%lx> "
> "is not supported\n", addr);
> return -EINVAL;
> }
Is it really neccessary for this fragment to create a line that
is greater than 80 characters long? Persumably the entire reason
that the printk line was split in the first place was to avoid
a long line.
[snip]
--
Horms
next prev parent reply other threads:[~2007-11-20 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1195523331-15303-1-git-send-email-joe@perches.com>
2007-11-20 1:47 ` [PATCH 01/59] arch/ia64: Add missing "space" Joe Perches
2007-11-20 6:54 ` Simon Horman [this message]
2007-11-20 7:09 ` Joe Perches
2007-11-20 7:41 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120065431.GC10490@verge.net.au \
--to=horms@verge.net.au \
--cc=jes@sgi.com \
--cc=joe@perches.com \
--cc=linux-altix@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox