* [PATCH 2 of 4] Spelling/punctuation fixes
@ 2007-12-12 15:07 Aron Griffis
2007-12-12 15:43 ` Aron Griffis
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aron Griffis @ 2007-12-12 15:07 UTC (permalink / raw)
To: linux-ia64
# HG changeset patch
# User Aron Griffis <aron@hp.com>
# Date 1197470463 18000
# Node ID 049467433cda01769d2f8c276fcfeb7d216658d7
# Parent 1161690ae81590dec4e97c52f07cf1798c11a97b
Spelling/punctuation fixes
Woah is not a word ;-)
diff -r 1161690ae815 -r 049467433cda arch/ia64/kernel/efi.c
--- a/arch/ia64/kernel/efi.c Tue Dec 11 21:53:55 2007 -0500
+++ b/arch/ia64/kernel/efi.c Wed Dec 12 09:41:03 2007 -0500
@@ -331,7 +331,7 @@ efi_memmap_walk_uc (efi_freemem_callback
}
/*
- * Look for the PAL_CODE region reported by EFI and maps it using an
+ * Looks for the PAL_CODE region reported by EFI and maps it using an
* ITR to enable safe PAL calls in virtual mode. See IA-64 Processor
* Abstraction Layer chapter 11 in ADAG
*/
@@ -372,7 +372,7 @@ efi_get_pal_addr (void)
* PAL code is guaranteed to be aligned on a power of 2 between
* 4k and 256KB and that only one ITR is needed to map it. This
* implies that the PAL code is always aligned on its size,
- * i.e., the closest matching page size supported by the TLB.
+ * i.e. the closest matching page size supported by the TLB.
* Therefore PAL code is guaranteed never to cross a 64MB unless
* it is bigger than 64MB (very unlikely!). So for now the
* following test is enough to determine whether or not we need
@@ -385,7 +385,7 @@ efi_get_pal_addr (void)
}
if (md->num_pages << EFI_PAGE_SHIFT > IA64_GRANULE_SIZE)
- panic("Woah! PAL code size bigger than a granule!");
+ panic("Whoa! PAL code size bigger than a granule!");
#if EFI_DEBUG
mask = ~((1 << IA64_GRANULE_SHIFT) - 1);
@@ -435,7 +435,7 @@ efi_init (void)
int i;
/*
- * it's too early to be able to use the standard kernel command line
+ * It's too early to be able to use the standard kernel command line
* support...
*/
for (cp = boot_command_line; *cp; ) {
@@ -465,9 +465,9 @@ efi_init (void)
* Verify the EFI Table
*/
if (efi.systab = NULL)
- panic("Woah! Can't find EFI system table.\n");
+ panic("Whoa! Can't find EFI system table.\n");
if (efi.systab->hdr.signature != EFI_SYSTEM_TABLE_SIGNATURE)
- panic("Woah! EFI system table signature incorrect\n");
+ panic("Whoa! EFI system table signature incorrect\n");
if ((efi.systab->hdr.revision >> 16) = 0)
printk(KERN_WARNING "Warning: EFI system table version "
"%d.%02d, expected 1.00 or greater\n",
@@ -1201,7 +1201,7 @@ efi_initialize_iomem_resources(struct re
if ((res = kzalloc(sizeof(struct resource),
GFP_KERNEL)) = NULL) {
printk(KERN_ERR
- "failed to alocate resource for iomem\n");
+ "failed to allocate resource for iomem\n");
return;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2 of 4] Spelling/punctuation fixes
2007-12-12 15:07 [PATCH 2 of 4] Spelling/punctuation fixes Aron Griffis
@ 2007-12-12 15:43 ` Aron Griffis
2007-12-13 23:30 ` Peter Chubb
2007-12-13 23:52 ` Aron Griffis
2 siblings, 0 replies; 4+ messages in thread
From: Aron Griffis @ 2007-12-12 15:43 UTC (permalink / raw)
To: linux-ia64
I guess I forgot my signoff on this one, if it matters for spelling
fixes...
# HG changeset patch
# User Aron Griffis <aron@hp.com>
# Date 1197470463 18000
# Node ID 049467433cda01769d2f8c276fcfeb7d216658d7
# Parent 1161690ae81590dec4e97c52f07cf1798c11a97b
Spelling/punctuation fixes
Woah is not a word ;-)
Signed-off-by: Aron Griffis <aron@hp.com>
diff -r 1161690ae815 -r 049467433cda arch/ia64/kernel/efi.c
--- a/arch/ia64/kernel/efi.c Tue Dec 11 21:53:55 2007 -0500
+++ b/arch/ia64/kernel/efi.c Wed Dec 12 09:41:03 2007 -0500
@@ -331,7 +331,7 @@ efi_memmap_walk_uc (efi_freemem_callback
}
/*
- * Look for the PAL_CODE region reported by EFI and maps it using an
+ * Looks for the PAL_CODE region reported by EFI and maps it using an
* ITR to enable safe PAL calls in virtual mode. See IA-64 Processor
* Abstraction Layer chapter 11 in ADAG
*/
@@ -372,7 +372,7 @@ efi_get_pal_addr (void)
* PAL code is guaranteed to be aligned on a power of 2 between
* 4k and 256KB and that only one ITR is needed to map it. This
* implies that the PAL code is always aligned on its size,
- * i.e., the closest matching page size supported by the TLB.
+ * i.e. the closest matching page size supported by the TLB.
* Therefore PAL code is guaranteed never to cross a 64MB unless
* it is bigger than 64MB (very unlikely!). So for now the
* following test is enough to determine whether or not we need
@@ -385,7 +385,7 @@ efi_get_pal_addr (void)
}
if (md->num_pages << EFI_PAGE_SHIFT > IA64_GRANULE_SIZE)
- panic("Woah! PAL code size bigger than a granule!");
+ panic("Whoa! PAL code size bigger than a granule!");
#if EFI_DEBUG
mask = ~((1 << IA64_GRANULE_SHIFT) - 1);
@@ -435,7 +435,7 @@ efi_init (void)
int i;
/*
- * it's too early to be able to use the standard kernel command line
+ * It's too early to be able to use the standard kernel command line
* support...
*/
for (cp = boot_command_line; *cp; ) {
@@ -465,9 +465,9 @@ efi_init (void)
* Verify the EFI Table
*/
if (efi.systab = NULL)
- panic("Woah! Can't find EFI system table.\n");
+ panic("Whoa! Can't find EFI system table.\n");
if (efi.systab->hdr.signature != EFI_SYSTEM_TABLE_SIGNATURE)
- panic("Woah! EFI system table signature incorrect\n");
+ panic("Whoa! EFI system table signature incorrect\n");
if ((efi.systab->hdr.revision >> 16) = 0)
printk(KERN_WARNING "Warning: EFI system table version "
"%d.%02d, expected 1.00 or greater\n",
@@ -1201,7 +1201,7 @@ efi_initialize_iomem_resources(struct re
if ((res = kzalloc(sizeof(struct resource),
GFP_KERNEL)) = NULL) {
printk(KERN_ERR
- "failed to alocate resource for iomem\n");
+ "failed to allocate resource for iomem\n");
return;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2 of 4] Spelling/punctuation fixes
2007-12-12 15:07 [PATCH 2 of 4] Spelling/punctuation fixes Aron Griffis
2007-12-12 15:43 ` Aron Griffis
@ 2007-12-13 23:30 ` Peter Chubb
2007-12-13 23:52 ` Aron Griffis
2 siblings, 0 replies; 4+ messages in thread
From: Peter Chubb @ 2007-12-13 23:30 UTC (permalink / raw)
To: linux-ia64
Some comments:
-- `i.e.' should usually be followed by a comma. Read it as
`that is' and see if the resulting sentence makes sense
without a comma.
-- Look for the PAL_CODE.... and map it using...
^
may be a nicer fix.
But it's mostly cosmetic anyway.
--
Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au
http://www.ertos.nicta.com.au ERTOS within National ICT Australia
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2 of 4] Spelling/punctuation fixes
2007-12-12 15:07 [PATCH 2 of 4] Spelling/punctuation fixes Aron Griffis
2007-12-12 15:43 ` Aron Griffis
2007-12-13 23:30 ` Peter Chubb
@ 2007-12-13 23:52 ` Aron Griffis
2 siblings, 0 replies; 4+ messages in thread
From: Aron Griffis @ 2007-12-13 23:52 UTC (permalink / raw)
To: linux-ia64
Peter Chubb wrote: [Thu Dec 13 2007, 06:30:27PM EST]
> Some comments:
> -- `i.e.' should usually be followed by a comma. Read it as
> `that is' and see if the resulting sentence makes sense
> without a comma.
Seems to be a matter of debate:
http://dictionary.reference.com/help/faq/language/g58.html
> -- Look for the PAL_CODE.... and map it using...
> ^
> may be a nicer fix.
I'll read it over. Your suggestion is probably best.
> But it's mostly cosmetic anyway.
Mostly? :-)
I'll likely just leave out that change. The comma doesn't offend my
sensibilties. I noticed it in passing and wasn't aware that "i.e."
and "e.g." are sometimes followed by a comma.
Thanks,
Aron
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-13 23:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-12 15:07 [PATCH 2 of 4] Spelling/punctuation fixes Aron Griffis
2007-12-12 15:43 ` Aron Griffis
2007-12-13 23:30 ` Peter Chubb
2007-12-13 23:52 ` Aron Griffis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox