public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 4/4] ia64: fix ptrace inside a namespace
@ 2008-02-05  7:43 akpm
  2008-02-05  9:49 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-02-05  7:43 UTC (permalink / raw)
  To: linux-ia64

From: Pavel Emelyanov <xemul@openvz.org>

The ia64 has its own sys_ptrace implementation and it was overlooked when the
pid namespaces patches were sent.

Use find_task_by_vpid() in it.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/ia64/kernel/ptrace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace arch/ia64/kernel/ptrace.c
--- a/arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace
+++ a/arch/ia64/kernel/ptrace.c
@@ -1437,7 +1437,7 @@ sys_ptrace (long request, pid_t pid, uns
 	ret = -ESRCH;
 	read_lock(&tasklist_lock);
 	{
-		child = find_task_by_pid(pid);
+		child = find_task_by_vpid(pid);
 		if (child) {
 			if (peek_or_poke)
 				child = find_thread_for_addr(child, addr);
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 4/4] ia64: fix ptrace inside a namespace
  2008-02-05  7:43 [patch 4/4] ia64: fix ptrace inside a namespace akpm
@ 2008-02-05  9:49 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-02-05  9:49 UTC (permalink / raw)
  To: linux-ia64

On Mon, Feb 04, 2008 at 11:43:04PM -0800, akpm@linux-foundation.org wrote:
> From: Pavel Emelyanov <xemul@openvz.org>
> 
> The ia64 has its own sys_ptrace implementation and it was overlooked when the
> pid namespaces patches were sent.
> 
> Use find_task_by_vpid() in it

The plan is to kill this code entirely and make ia64 look like other
ptrace implementations.  Please double check this doesn't cause merge
issues with the hopefully pending rewrite of the ia64 ptrace code.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-05  9:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-05  7:43 [patch 4/4] ia64: fix ptrace inside a namespace akpm
2008-02-05  9:49 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox