[PATCH 03/28] ia64/xen: increase IA64_MAX_RSVD_REGIONS.

[PATCH 03/28] ia64/xen: increase IA64_MAX_RSVD_REGIONS.

[Isaku Yamahata]

Xenlinux/ia64 needs to reserve one more region passed from xen hypervisor
as start info.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 include/asm-ia64/meminit.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/include/asm-ia64/meminit.h b/include/asm-ia64/meminit.h
index f93308f..7c12c08 100644
--- a/include/asm-ia64/meminit.h
+++ b/include/asm-ia64/meminit.h
@@ -18,10 +18,17 @@
  * 	- crash dumping code reserved region
  * 	- Kernel memory map built from EFI memory map
  * 	- ELF core header
+ * ifdef CONFIG_XEN
+ *	- xen start info
+ * endif
  *
  * More could be added if necessary
  */
+#ifdef CONFIG_XEN
 #define IA64_MAX_RSVD_REGIONS 8
+#else
+#define IA64_MAX_RSVD_REGIONS 9
+#endif
 
 struct rsvd_region {
 	unsigned long start;	/* virtual address of beginning of element */
-- 
1.5.3

Re: [PATCH 03/28] ia64/xen: increase IA64_MAX_RSVD_REGIONS.

[Robin Holt]

On Fri, Feb 22, 2008 at 02:10:19PM +0900, Isaku Yamahata wrote:
> Xenlinux/ia64 needs to reserve one more region passed from xen hypervisor
> as start info.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
>  include/asm-ia64/meminit.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/include/asm-ia64/meminit.h b/include/asm-ia64/meminit.h
> index f93308f..7c12c08 100644
> --- a/include/asm-ia64/meminit.h
> +++ b/include/asm-ia64/meminit.h
> @@ -18,10 +18,17 @@
>   * 	- crash dumping code reserved region
>   * 	- Kernel memory map built from EFI memory map
>   * 	- ELF core header
> + * ifdef CONFIG_XEN
> + *	- xen start info
> + * endif
>   *
>   * More could be added if necessary
>   */
> +#ifdef CONFIG_XEN
>  #define IA64_MAX_RSVD_REGIONS 8
> +#else
> +#define IA64_MAX_RSVD_REGIONS 9
> +#endif

This one seems upside down to me.  You are saying there is an additional
region when CONFIG_XEN, but you are defining it larger for !CONFIG_XEN.
I concede the point that I know nothing about Xen, so please straighten
me out here.

Thanks,
Robin

Re: [PATCH 03/28] ia64/xen: increase IA64_MAX_RSVD_REGIONS.

[Isaku Yamahata]

On Thu, Feb 21, 2008 at 11:33:16PM -0600, Robin Holt wrote:
> On Fri, Feb 22, 2008 at 02:10:19PM +0900, Isaku Yamahata wrote:
> > Xenlinux/ia64 needs to reserve one more region passed from xen hypervisor
> > as start info.
> > 
> > Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> > ---
> >  include/asm-ia64/meminit.h |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/asm-ia64/meminit.h b/include/asm-ia64/meminit.h
> > index f93308f..7c12c08 100644
> > --- a/include/asm-ia64/meminit.h
> > +++ b/include/asm-ia64/meminit.h
> > @@ -18,10 +18,17 @@
> >   * 	- crash dumping code reserved region
> >   * 	- Kernel memory map built from EFI memory map
> >   * 	- ELF core header
> > + * ifdef CONFIG_XEN
> > + *	- xen start info
> > + * endif
> >   *
> >   * More could be added if necessary
> >   */
> > +#ifdef CONFIG_XEN
> >  #define IA64_MAX_RSVD_REGIONS 8
> > +#else
> > +#define IA64_MAX_RSVD_REGIONS 9
> > +#endif
> 
> This one seems upside down to me.  You are saying there is an additional
> region when CONFIG_XEN, but you are defining it larger for !CONFIG_XEN.
> I concede the point that I know nothing about Xen, so please straighten
> me out here.

Thank you for review. You're absolutely correct.

---
ia64/xen: increase IA64_MAX_RSVD_REGIONS.

Xenlinux/ia64 needs to reserve one more region passed from xen hypervisor
as start info.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 include/asm-ia64/meminit.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/include/asm-ia64/meminit.h b/include/asm-ia64/meminit.h
index f93308f..3de9c74 100644
--- a/include/asm-ia64/meminit.h
+++ b/include/asm-ia64/meminit.h
@@ -18,10 +18,17 @@
  * 	- crash dumping code reserved region
  * 	- Kernel memory map built from EFI memory map
  * 	- ELF core header
+ * ifdef CONFIG_XEN
+ *	- xen start info
+ * endif
  *
  * More could be added if necessary
  */
+#ifndef CONFIG_XEN
 #define IA64_MAX_RSVD_REGIONS 8
+#else
+#define IA64_MAX_RSVD_REGIONS 9
+#endif
 
 struct rsvd_region {
 	unsigned long start;	/* virtual address of beginning of element */
-- 
1.5.3



-- 
yamahata

Re: [PATCH 03/28] ia64/xen: increase IA64_MAX_RSVD_REGIONS.

[Bjorn Helgaas]

On Thursday 21 February 2008 10:10:19 pm Isaku Yamahata wrote:
> Xenlinux/ia64 needs to reserve one more region passed from xen hypervisor
> as start info.

I don't think it's really worth adding an ifdef here to save
one struct rsvd_region (two longs).  Why not just increase
IA64_MAX_RSVD_REGIONS to 9 for everybody, and get rid of the
ifdef?

> +#ifdef CONFIG_XEN
>  #define IA64_MAX_RSVD_REGIONS 8
> +#else
> +#define IA64_MAX_RSVD_REGIONS 9
> +#endif
>  
>  struct rsvd_region {
>  	unsigned long start;	/* virtual address of beginning of element */

Re: [PATCH 03/28] ia64/xen: increase IA64_MAX_RSVD_REGIONS.

[Isaku Yamahata]

On Mon, Feb 25, 2008 at 10:18:52AM -0700, Bjorn Helgaas wrote:
> On Thursday 21 February 2008 10:10:19 pm Isaku Yamahata wrote:
> > Xenlinux/ia64 needs to reserve one more region passed from xen hypervisor
> > as start info.
> 
> I don't think it's really worth adding an ifdef here to save
> one struct rsvd_region (two longs).  Why not just increase
> IA64_MAX_RSVD_REGIONS to 9 for everybody, and get rid of the
> ifdef?

Thank you for comment. It works for me.
ia64/xen: increase IA64_MAX_RSVD_REGIONS.

Xenlinux/ia64 needs to reserve one more region passed from xen hypervisor
as start info.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 include/asm-ia64/meminit.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/asm-ia64/meminit.h b/include/asm-ia64/meminit.h
index f93308f..8de94e2 100644
--- a/include/asm-ia64/meminit.h
+++ b/include/asm-ia64/meminit.h
@@ -18,10 +18,11 @@
  * 	- crash dumping code reserved region
  * 	- Kernel memory map built from EFI memory map
  * 	- ELF core header
+ *	- xen start info if CONFIG_XEN
  *
  * More could be added if necessary
  */
-#define IA64_MAX_RSVD_REGIONS 8
+#define IA64_MAX_RSVD_REGIONS 9
 
 struct rsvd_region {
 	unsigned long start;	/* virtual address of beginning of element */
-- 
1.5.3



-- 
yamahata