Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

[Arjan van de Ven]

On Tue, 29 Apr 2008 23:47:17 +0200
"stephane eranian" <eranian@googlemail.com> wrote:

> 
>  As usual all files and more detailed changelogs can be downloaded
> from our website at:
> 
>         http://perfmon.sourceforge.net

it hides well there ;(
the website seems to only offer a 2003 version for download.. I doubt that that is the right one..

Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

[Arjan van de Ven]

On Wed, 30 Apr 2008 15:11:11 +0200
"stephane eranian" <eranian@googlemail.com> wrote:

> Sorry,
> 
> It's http://perfmon2.sf.net
> 
> 

hummmmm, I wonder why perfmon wants to reimplement half of the PCI layer...

+extern spinlock_t pci_config_lock;
+
+#define PCI_CONF1_ADDRESS(bus, devfn, reg) \
+       (0x80000000 | ((reg & 0xF00) << 16) | ((bus & 0xFF) << 16) \
+       | (devfn << 8) | (reg & 0xFC))
+
+#define is_ibs_pmc(x) (x = 4 || x = 5)
+
+static int pci_read(unsigned int seg, unsigned int bus,
+                   unsigned int devfn, int reg, int len, u32 *value)
+{
+       unsigned long flags;

especially since this doesn't seem to use the proper config space abstractions :(

Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

[Arjan van de Ven]

On Wed, 30 Apr 2008 15:51:39 +0200
"stephane eranian" <eranian@googlemail.com> wrote:

> If I recall, AMD said that this special initialization would
> eventually migrate into the core kernel. The pci_read() may be there
> because it was not exported by the kernel (this particular code lives
> in a kernel module).

... yet your patch adds an EXPORT_SYMBOL() just to make this specific function possible. Weird.

I find it hard to believe that there would be no code in the kernel to
read or write config space of a device you have..... :)
In fact I bet 80% of the drivers in the tree use it.

2.6.25 new perfmon kernel patch + libpfm + pfmon available

[stephane eranian]

Hello,

 I have released the perfmon2 kernel patch for kernel v2.6.25. There is
 no major features. However, there were a major restructuring of the code
 to make it more readable, isolate features per module. The header files
 have also been restructured to separate user vs. kernel, and generic only
 vs. shared with arch. The restructuring of the interrupt handler yielded
 a nice 15% latency improvement on single counter sampling runs on X86.
 This new structure will make it easier to extract features and merge them
 with the mainline kernel.

 In the time frame of 2.6.26, I will push a few bits and pieces to LKML
 for final review and integration.

 Here are some of the kernel changes:
  - Cell updates (Carl Love, Takashi Yamamoto)
  - new perfmon_debug boot option to enable debug (Robert Richter)
  - several bugs fixes on Itanium, MIPS and generic hrtimer management
  - Power locking updates (Corey Ashford)

 There is also a new release for libpfm, now at version 3.4.
 The changes include:
  - AMD Phenom (a.k.a. Barcelona) IBS support (Robert Richter)
  - Python bindings and examples (Arun Sharma)
  - environment variable support to enable debugging
  - auto-detection of syscall base number for 2.6.24 and 2.6.25
  - new multi-threaded self-sampling example (Mark W. Krentel)
  - man pages cleanups (Steve Kaufmann)

 Special thanks to Arun (Google). The Python bindings are a nice addition
 to libpfm especially for prototyping and writing testsuites.

 Finally, a new major version of pfmon, now at pfmon-3.4.
 Among the many changes:
  - added support for dmalloc (Andrzej Nowak)
  - updated support for Cell processor (Takashi Yamamoto)
  - possibility to terminate pfmon cleanly with SIGTERM
  - --follow-fork and derivatives fixed on Itanium and other platforms
  - tracking of dlopen now works on mixed ABI environments
  - lots of bugs fixes

 As usual all files and more detailed changelogs can be downloaded from our
 website at:

        http://perfmon.sourceforge.net

 Enjoy,

Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

[stephane eranian]

Sorry,

It's http://perfmon2.sf.net



On Tue, Apr 29, 2008 at 5:08 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> On Tue, 29 Apr 2008 23:47:17 +0200
>  "stephane eranian" <eranian@googlemail.com> wrote:
>
>  >
>  >  As usual all files and more detailed changelogs can be downloaded
>  > from our website at:
>  >
>  >         http://perfmon.sourceforge.net
>
>  it hides well there ;(
>  the website seems to only offer a 2003 version for download.. I doubt that that is the right one..
>

Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

[stephane eranian]

If I recall, AMD said that this special initialization would eventually migrate
into the core kernel. The pci_read() may be there because it was not exported
by the kernel (this particular code lives in a kernel module).

If you think there is now enough support in the core kernel to do this
initialization
then I'd be happy to remove this piece of code.




On Tue, Apr 29, 2008 at 5:33 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> On Wed, 30 Apr 2008 15:11:11 +0200
>
> "stephane eranian" <eranian@googlemail.com> wrote:
>
>
> > Sorry,
>  >
>  > It's http://perfmon2.sf.net
>  >
>  >
>
>  hummmmm, I wonder why perfmon wants to reimplement half of the PCI layer...
>
>  +extern spinlock_t pci_config_lock;
>  +
>  +#define PCI_CONF1_ADDRESS(bus, devfn, reg) \
>  +       (0x80000000 | ((reg & 0xF00) << 16) | ((bus & 0xFF) << 16) \
>  +       | (devfn << 8) | (reg & 0xFC))
>  +
>  +#define is_ibs_pmc(x) (x = 4 || x = 5)
>  +
>  +static int pci_read(unsigned int seg, unsigned int bus,
>  +                   unsigned int devfn, int reg, int len, u32 *value)
>  +{
>  +       unsigned long flags;
>
>  especially since this doesn't seem to use the proper config space abstractions :(
>

Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

[stephane eranian]

Hello,


Several people noticed there was a typo in the website url.
The actual web site is:

      http://perfmon2.sf.net


Sorry about that.

On Tue, Apr 29, 2008 at 11:47 PM, stephane eranian
<eranian@googlemail.com> wrote:
>
> Hello,
>
>   I have released the perfmon2 kernel patch for kernel v2.6.25. There is
>   no major features. However, there were a major restructuring of the code
>   to make it more readable, isolate features per module. The header files
>   have also been restructured to separate user vs. kernel, and generic only
>   vs. shared with arch. The restructuring of the interrupt handler yielded
>   a nice 15% latency improvement on single counter sampling runs on X86.
>   This new structure will make it easier to extract features and merge them
>   with the mainline kernel.
>
>   In the time frame of 2.6.26, I will push a few bits and pieces to LKML
>   for final review and integration.
>
>   Here are some of the kernel changes:
>   - Cell updates (Carl Love, Takashi Yamamoto)
>   - new perfmon_debug boot option to enable debug (Robert Richter)
>   - several bugs fixes on Itanium, MIPS and generic hrtimer management
>   - Power locking updates (Corey Ashford)
>
>   There is also a new release for libpfm, now at version 3.4.
>   The changes include:
>   - AMD Phenom (a.k.a. Barcelona) IBS support (Robert Richter)
>   - Python bindings and examples (Arun Sharma)
>   - environment variable support to enable debugging
>   - auto-detection of syscall base number for 2.6.24 and 2.6.25
>   - new multi-threaded self-sampling example (Mark W. Krentel)
>   - man pages cleanups (Steve Kaufmann)
>
>   Special thanks to Arun (Google). The Python bindings are a nice addition
>   to libpfm especially for prototyping and writing testsuites.
>
>   Finally, a new major version of pfmon, now at pfmon-3.4.
>   Among the many changes:
>   - added support for dmalloc (Andrzej Nowak)
>   - updated support for Cell processor (Takashi Yamamoto)
>   - possibility to terminate pfmon cleanly with SIGTERM
>   - --follow-fork and derivatives fixed on Itanium and other platforms
>   - tracking of dlopen now works on mixed ABI environments
>   - lots of bugs fixes
>
>   As usual all files and more detailed changelogs can be downloaded from our
>   website at:
>
>         http://perfmon.sourceforge.net
>
>   Enjoy,
>

Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available

[Robert Richter]

On 29.04.08 09:42:18, Arjan van de Ven wrote:
> On Wed, 30 Apr 2008 15:51:39 +0200
> "stephane eranian" <eranian@googlemail.com> wrote:
> 
> > If I recall, AMD said that this special initialization would
> > eventually migrate into the core kernel. The pci_read() may be there
> > because it was not exported by the kernel (this particular code lives
> > in a kernel module).
> 
> ... yet your patch adds an EXPORT_SYMBOL() just to make this specific function possible. Weird.
> 
> I find it hard to believe that there would be no code in the kernel to
> read or write config space of a device you have..... :)
> In fact I bet 80% of the drivers in the tree use it.

Access to extended config space for AMD northbridges was not yet
implemented. Recent patches from Yinghai Lu fix this. I will send a
patch that uses the in-kernel functions.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com