public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ia64: export cpu_core_map
@ 2008-07-29 11:12 Ben Hutchings
  2008-07-29 12:09 ` Robin Holt
  2008-07-29 12:28 ` Ben Hutchings
  0 siblings, 2 replies; 3+ messages in thread
From: Ben Hutchings @ 2008-07-29 11:12 UTC (permalink / raw)
  To: linux-ia64

cpu_core_map is referenced by the topology_core_siblings() macro, which is
now used by the sfc driver.  Matthew Wilcox reported that the driver failed
to link because that symbol is not exported.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
I have not yet tested this as we have limited ia64 kit here.  Matthew,
please could you check that this builds at least?

Ben.
---
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
index 03f1a99..6cb0927 100644
--- a/arch/ia64/kernel/smpboot.c
+++ b/arch/ia64/kernel/smpboot.c
@@ -138,6 +138,7 @@ cpumask_t cpu_possible_map = CPU_MASK_NONE;
 EXPORT_SYMBOL(cpu_possible_map);
 
 cpumask_t cpu_core_map[NR_CPUS] __cacheline_aligned;
+EXPORT_SYMBOL(cpu_core_map);
 DEFINE_PER_CPU_SHARED_ALIGNED(cpumask_t, cpu_sibling_map);
 EXPORT_PER_CPU_SYMBOL(cpu_sibling_map);
 

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
 ot speaking for my employer; that's the marketing department's job.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ia64: export cpu_core_map
  2008-07-29 11:12 [PATCH] ia64: export cpu_core_map Ben Hutchings
@ 2008-07-29 12:09 ` Robin Holt
  2008-07-29 12:28 ` Ben Hutchings
  1 sibling, 0 replies; 3+ messages in thread
From: Robin Holt @ 2008-07-29 12:09 UTC (permalink / raw)
  To: linux-ia64

On Tue, Jul 29, 2008 at 12:12:26PM +0100, Ben Hutchings wrote:
> cpu_core_map is referenced by the topology_core_siblings() macro, which is
> now used by the sfc driver.  Matthew Wilcox reported that the driver failed
> to link because that symbol is not exported.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> I have not yet tested this as we have limited ia64 kit here.  Matthew,
> please could you check that this builds at least?

I had tested it last night when I CC'd you on the patch I sent to the
ia64 mailing list.

I have booted it on a bunch of different sn2 ia64 boxes, but none with
your sfc network adapter (whatever that is).  It does, however, build ;)

Thanks,
Robin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ia64: export cpu_core_map
  2008-07-29 11:12 [PATCH] ia64: export cpu_core_map Ben Hutchings
  2008-07-29 12:09 ` Robin Holt
@ 2008-07-29 12:28 ` Ben Hutchings
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2008-07-29 12:28 UTC (permalink / raw)
  To: linux-ia64

Robin Holt wrote:
> On Tue, Jul 29, 2008 at 12:12:26PM +0100, Ben Hutchings wrote:
> > cpu_core_map is referenced by the topology_core_siblings() macro, which is
> > now used by the sfc driver.  Matthew Wilcox reported that the driver failed
> > to link because that symbol is not exported.
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> > I have not yet tested this as we have limited ia64 kit here.  Matthew,
> > please could you check that this builds at least?
> 
> I had tested it last night when I CC'd you on the patch I sent to the
> ia64 mailing list.

Sorry, not sure how I missed that.  Now I look over the archive, I see
Matthew also posted the same patch but didn't cc me.

> I have booted it on a bunch of different sn2 ia64 boxes, but none with
> your sfc network adapter (whatever that is).

It's a PCI Express 10G Ethernet controller, but that's not important right
now.

> It does, however, build ;)

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-29 12:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-29 11:12 [PATCH] ia64: export cpu_core_map Ben Hutchings
2008-07-29 12:09 ` Robin Holt
2008-07-29 12:28 ` Ben Hutchings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox