* [patch] IA64: make rsvd_region and num_rsvd_regions static
@ 2008-08-05 9:57 Simon Horman
2008-08-12 20:47 ` Luck, Tony
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2008-08-05 9:57 UTC (permalink / raw)
To: linux-ia64, linux-kernel; +Cc: Tony Luck
rsvd_region and num_rsvd_regions are only accessed in
arch/ia64/kernel/setup.c, so they should be static.
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: linux-2.6/arch/ia64/kernel/setup.c
=================================--- linux-2.6.orig/arch/ia64/kernel/setup.c 2008-08-02 17:38:02.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/setup.c 2008-08-02 17:38:20.000000000 +1000
@@ -132,8 +132,8 @@ EXPORT_SYMBOL(ia64_max_iommu_merge_mask)
/*
* We use a special marker for the end of memory and it uses the extra (+1) slot
*/
-struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata;
-int num_rsvd_regions __initdata;
+static struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata;
+static int num_rsvd_regions __initdata;
/*
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [patch] IA64: make rsvd_region and num_rsvd_regions static
2008-08-05 9:57 [patch] IA64: make rsvd_region and num_rsvd_regions static Simon Horman
@ 2008-08-12 20:47 ` Luck, Tony
2008-08-12 23:21 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Luck, Tony @ 2008-08-12 20:47 UTC (permalink / raw)
To: Simon Horman, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
> rsvd_region and num_rsvd_regions are only accessed in
> arch/ia64/kernel/setup.c, so they should be static.
Are you looking at -mm or linux-next? In my tree I see:
arch/ia64/mm/contig.c: for (i = 0; i < num_rsvd_regions; i++) {
arch/ia64/mm/contig.c: range_end = min(end, rsvd_region[i].start & PAGE_MASK);
arch/ia64/mm/contig.c: free_start = PAGE_ALIGN(rsvd_region[i].end);
-Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] IA64: make rsvd_region and num_rsvd_regions static
2008-08-12 20:47 ` Luck, Tony
@ 2008-08-12 23:21 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2008-08-12 23:21 UTC (permalink / raw)
To: Luck, Tony; +Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Aug 12, 2008 at 01:47:37PM -0700, Luck, Tony wrote:
> > rsvd_region and num_rsvd_regions are only accessed in
> > arch/ia64/kernel/setup.c, so they should be static.
>
> Are you looking at -mm or linux-next? In my tree I see:
Whatever I was looking at, I was wrong. Sorry for the noise.
> arch/ia64/mm/contig.c: for (i = 0; i < num_rsvd_regions; i++) {
> arch/ia64/mm/contig.c: range_end = min(end, rsvd_region[i].start & PAGE_MASK);
> arch/ia64/mm/contig.c: free_start = PAGE_ALIGN(rsvd_region[i].end);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-12 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-05 9:57 [patch] IA64: make rsvd_region and num_rsvd_regions static Simon Horman
2008-08-12 20:47 ` Luck, Tony
2008-08-12 23:21 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox