From: Matthew Wilcox <matthew@wil.cx>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH]Export the symbol ia64_patch_imm64.
Date: Tue, 09 Sep 2008 05:19:03 +0000 [thread overview]
Message-ID: <20080909051903.GT2772@parisc-linux.org> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01923FC8@pdsmsx415.ccr.corp.intel.com>
On Tue, Sep 09, 2008 at 01:11:33PM +0800, Zhang, Xiantao wrote:
> diff --git a/arch/ia64/kernel/ia64_ksyms.c
> b/arch/ia64/kernel/ia64_ksyms.c
> index 6da1f20..b872f54 100644
> --- a/arch/ia64/kernel/ia64_ksyms.c
> +++ b/arch/ia64/kernel/ia64_ksyms.c
> @@ -86,6 +86,9 @@ EXPORT_SYMBOL(ia64_save_scratch_fpregs);
> #include <asm/unwind.h>
> EXPORT_SYMBOL(unw_init_running);
>
> +#include <asm/patch.h>
> +EXPORT_SYMBOL_GPL(ia64_patch_imm64);
This shouldn't be exported in ia64_ksyms.c, it should be exported from
arch/ia64/kernel/patch.c. See Documentation/CodingStyle, chapter 6.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2008-09-09 5:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 5:30 [PATCH]Export the symbol ia64_patch_imm64 Zhang, Xiantao
2008-09-08 17:39 ` Luck, Tony
2008-09-09 5:11 ` Zhang, Xiantao
2008-09-09 5:19 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909051903.GT2772@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox