[PATCH]Export the symbol ia64_patch_imm64.

[PATCH]Export the symbol ia64_patch_imm64.

[Zhang, Xiantao]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

From 0dfc91f92875523cd29ae5f4719f25a21168d637 Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Mon, 8 Sep 2008 13:10:00 +0800
Subject: [PATCH] ia64: Export the symbol ia64_patch_imm64.

Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 arch/ia64/kernel/ia64_ksyms.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/kernel/ia64_ksyms.c
b/arch/ia64/kernel/ia64_ksyms.c
index 6da1f20..92cb478 100644
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -86,6 +86,9 @@ EXPORT_SYMBOL(ia64_save_scratch_fpregs);
 #include <asm/unwind.h>
 EXPORT_SYMBOL(unw_init_running);
 
+#include <asm/patch.h>
+EXPORT_SYMBOL(ia64_patch_imm64);
+
 #ifdef ASM_SUPPORTED
 # ifdef CONFIG_SMP
 #  if (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
-- 
1.5.1

[-- Attachment #2: 0001-ia64-Export-the-symbol-ia64_patch_imm64.patch --]
[-- Type: application/octet-stream, Size: 821 bytes --]

From 0dfc91f92875523cd29ae5f4719f25a21168d637 Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Mon, 8 Sep 2008 13:10:00 +0800
Subject: [PATCH] ia64: Export the symbol ia64_patch_imm64.

Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 arch/ia64/kernel/ia64_ksyms.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/kernel/ia64_ksyms.c b/arch/ia64/kernel/ia64_ksyms.c
index 6da1f20..92cb478 100644
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -86,6 +86,9 @@ EXPORT_SYMBOL(ia64_save_scratch_fpregs);
 #include <asm/unwind.h>
 EXPORT_SYMBOL(unw_init_running);
 
+#include <asm/patch.h>
+EXPORT_SYMBOL(ia64_patch_imm64);
+
 #ifdef ASM_SUPPORTED
 # ifdef CONFIG_SMP
 #  if (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
-- 
1.5.1

RE: [PATCH]Export the symbol ia64_patch_imm64.

[Luck, Tony]

Why does this need to be exported?  I'm assuming
that kvm is involved ... but you should provide
some details in the patch so that the GIT commit
will have some descriptive value.

Is it a legacy case?  If not, then we should use
EXPORT_SYMBOL_GPL.

-Tony

RE: [PATCH]Export the symbol ia64_patch_imm64.

[Zhang, Xiantao]

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]

Luck, Tony wrote:
> Why does this need to be exported?  I'm assuming
> that kvm is involved ... but you should provide
> some details in the patch so that the GIT commit
> will have some descriptive value.

Okay, added in the updated version. 
 
> Is it a legacy case?  If not, then we should use
> EXPORT_SYMBOL_GPL.
Since kvm is only merged into linux-2.6.26 and newer version, we don't
need to consider legacy cases. So EXPORT_SYMBOL_GPL is better, Thanks!
Xiantao

From 15760b3bf350de562f7138fc84d128369543f17f Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Tue, 9 Sep 2008 09:52:07 +0800
Subject: [PATCH] ia64: Export the symbol ia64_patch_imm64.

In kvm module, it uses ia64_patch_imm64 to patch some instructions of
itself
to reduce cost, when it calls PAL virtualization services.

Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 arch/ia64/kernel/ia64_ksyms.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/kernel/ia64_ksyms.c
b/arch/ia64/kernel/ia64_ksyms.c
index 6da1f20..b872f54 100644
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -86,6 +86,9 @@ EXPORT_SYMBOL(ia64_save_scratch_fpregs);
 #include <asm/unwind.h>
 EXPORT_SYMBOL(unw_init_running);
 
+#include <asm/patch.h>
+EXPORT_SYMBOL_GPL(ia64_patch_imm64);
+
 #ifdef ASM_SUPPORTED
 # ifdef CONFIG_SMP
 #  if (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
-- 
1.5.1


[-- Attachment #2: 0001-ia64-Export-the-symbol-ia64_patch_imm64.patch --]
[-- Type: application/octet-stream, Size: 962 bytes --]

From 15760b3bf350de562f7138fc84d128369543f17f Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@intel.com>
Date: Tue, 9 Sep 2008 09:52:07 +0800
Subject: [PATCH] ia64: Export the symbol ia64_patch_imm64.

In kvm module, it uses ia64_patch_imm64 to patch some instructions of itself
to reduce cost, when it calls PAL virtualization services.

Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
---
 arch/ia64/kernel/ia64_ksyms.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/kernel/ia64_ksyms.c b/arch/ia64/kernel/ia64_ksyms.c
index 6da1f20..b872f54 100644
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -86,6 +86,9 @@ EXPORT_SYMBOL(ia64_save_scratch_fpregs);
 #include <asm/unwind.h>
 EXPORT_SYMBOL(unw_init_running);
 
+#include <asm/patch.h>
+EXPORT_SYMBOL_GPL(ia64_patch_imm64);
+
 #ifdef ASM_SUPPORTED
 # ifdef CONFIG_SMP
 #  if (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
-- 
1.5.1

Re: [PATCH]Export the symbol ia64_patch_imm64.

[Matthew Wilcox]

On Tue, Sep 09, 2008 at 01:11:33PM +0800, Zhang, Xiantao wrote:
> diff --git a/arch/ia64/kernel/ia64_ksyms.c
> b/arch/ia64/kernel/ia64_ksyms.c
> index 6da1f20..b872f54 100644
> --- a/arch/ia64/kernel/ia64_ksyms.c
> +++ b/arch/ia64/kernel/ia64_ksyms.c
> @@ -86,6 +86,9 @@ EXPORT_SYMBOL(ia64_save_scratch_fpregs);
>  #include <asm/unwind.h>
>  EXPORT_SYMBOL(unw_init_running);
>  
> +#include <asm/patch.h>
> +EXPORT_SYMBOL_GPL(ia64_patch_imm64);

This shouldn't be exported in ia64_ksyms.c, it should be exported from
arch/ia64/kernel/patch.c.  See Documentation/CodingStyle, chapter 6.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."