From: Grant Grundler <grundler@parisc-linux.org>
To: linux-driver@qlogic.com
Cc: netdev@vger.kernel.org, ron.mercer@qlogic.com,
linux-ia64@vger.kernel.org
Subject: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit
Date: Mon, 13 Oct 2008 06:06:15 +0000 [thread overview]
Message-ID: <20081013060615.GB29358@colo.lackof.org> (raw)
QLGE driver only supports 4k, 8k, and 64k pages.
Default page size on ia64 is 16k. Compile fails with:
drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function)
Patch below makes the cause of the compile failure obvious.
(Better would be to support 16k pages but I don't have the HW or interest.)
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index c37ea43..cf68503 100644
--- a/drivers/net/qlge/qlge.h
+++ b/drivers/net/qlge/qlge.h
@@ -60,6 +60,8 @@
#define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2)
#elif (PAGE_SHIFT = 16) /* 64k pages */
#define TX_DESC_PER_OAL 0
+#else
+#error QLGE Driver only supports 4k, 8k, or 64k CPU page size.
#endif
#define DB_PAGE_SIZE 4096
next reply other threads:[~2008-10-13 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 6:06 Grant Grundler [this message]
2008-10-13 6:09 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14 1:54 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Ron Mercer
2008-10-14 2:03 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14 2:19 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Matthew Wilcox
2008-10-14 2:31 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14 2:53 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Ron Mercer
2008-10-14 5:56 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013060615.GB29358@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=linux-driver@qlogic.com \
--cc=linux-ia64@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox