From: Matthew Wilcox <matthew@wil.cx>
To: David Miller <davem@davemloft.net>
Cc: ron.mercer@qlogic.com, grundler@parisc-linux.org,
linux-driver@qlogic.com, netdev@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure
Date: Tue, 14 Oct 2008 02:19:02 +0000 [thread overview]
Message-ID: <20081014021902.GY25780@parisc-linux.org> (raw)
In-Reply-To: <20081013.190345.20202604.davem@davemloft.net>
On Mon, Oct 13, 2008 at 07:03:45PM -0700, David Miller wrote:
> From: Ron Mercer <ron.mercer@qlogic.com>
> Date: Mon, 13 Oct 2008 18:54:55 -0700
>
> > This ASIC does support all page sizes. For 4k and 8k page size the TX control block needs an external scatter gather list. For page sizes larger than 8k the max frags is satisfied by the original TX control block.
>
> I'm not applying this. I _explicitly_ said I would not apply a
> solution like this.
>
> I waited for you guys all day for this?!?!
>
> We need to find a way to make this a Kconfig dependency.
>
> Build failures are absolutely unacceptable.
Um, Dave, I think you misread his patch.
All it does it make the '64k case' the 'every other size case'. There's
no build failure with Ron's patch.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-10-14 2:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 6:06 [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit Grant Grundler
2008-10-13 6:09 ` David Miller
2008-10-14 1:54 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Ron Mercer
2008-10-14 2:03 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
2008-10-14 2:19 ` Matthew Wilcox [this message]
2008-10-14 2:31 ` David Miller
2008-10-14 2:53 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Ron Mercer
2008-10-14 5:56 ` [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014021902.GY25780@parisc-linux.org \
--to=matthew@wil.cx \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=linux-driver@qlogic.com \
--cc=linux-ia64@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox