public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-ia64@vger.kernel.org,
	Linux Kernel ML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joerg.roedel@amd.com>
Subject: [Q] Why does dma_alloc_coherent() of ia64 GFP_DMA?
Date: Mon, 10 Nov 2008 04:47:51 +0000	[thread overview]
Message-ID: <20081110121123.F82A.E1E9C6FF@jp.fujitsu.com> (raw)


Hello. 

I have a (may be dumb) question about dma_alloc_coherent() for ia64.


Why does dma_alloc_coherent() of ia64 force GFP_DMA yet?
And why is swiotlb_dma_alloc_coherent() default routine of
platform_dma_alloc_coherent()?

-------
#define dma_alloc_coherent(dev, size, handle, gfp)      \
        platform_dma_alloc_coherent(dev, size, handle, (gfp) | GFP_DMA)
--------

Even if a device allows over 4G access and the driver doesn't specify
GFP_DMA, dma_alloc_coherent() returns under 4G area.
I guess many people think this is not so big issue because drivers require
very small memory generally.

However, I think this has the possibility of a finishing blow of OOM.
For example,

  1) Page caches occupy normal zone, and DMA zone is free.
  2) A user's application requires a few GB memory and mlock it.
     All DMA zone is occupied by it.
  3) A device which allows over 4GB is hot-added.
     But dma_alloc_coherent() try to allocate DMA zone.
     Then OOM occurs because there is no freeable pages.

I heard there are some users who require a few GB mlock.
There are similar trouble in past. 


If GFP_DMA is removed from above definition of dma_alloc_coherent(),
what will happen?

If it is not allowed, how is followings?

dma_alloc_coherent()
  -> platform_dma_alloc_coherent()
       -> normal_alloc_coherent()
          {
                 if (dma_mask allow over 4G)
                        ret = __get_free_pages();
				:
                        (check validation of returned address)
				:
                 else 
                        swiotlb_alloc_coherent();
          }
}

If I'm something misunderstanding, please let me know.


Thanks.

-- 
Yasunori Goto 



             reply	other threads:[~2008-11-10  4:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10  4:47 Yasunori Goto [this message]
2008-11-10 12:59 ` [Q] Why does dma_alloc_coherent() of ia64 GFP_DMA? Andi Kleen
2008-11-10 19:07   ` Robin Holt
2008-11-10 21:57     ` Christoph Lameter
2008-11-11  5:14   ` Yasunori Goto
2008-11-11  5:48   ` FUJITA Tomonori
2008-11-10 22:06 ` Christoph Lameter
2008-11-11  5:39   ` Yasunori Goto
2008-11-11 20:34     ` Christoph Lameter
2008-11-11  5:53   ` FUJITA Tomonori
2008-11-11 20:32     ` Christoph Lameter
2008-11-12  1:40       ` FUJITA Tomonori
2008-11-11  5:41 ` FUJITA Tomonori
2008-11-11  6:21   ` Yasunori Goto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081110121123.F82A.E1E9C6FF@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=joerg.roedel@amd.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox