* [PATCH] ia64: don't need cpu_set() when migrate_platform_irqs()
@ 2009-02-06 16:49 Alex Chiang
0 siblings, 0 replies; only message in thread
From: Alex Chiang @ 2009-02-06 16:49 UTC (permalink / raw)
To: tony.luck; +Cc: linux-ia64, linux-kernel
Commit e7b14036 (prevent ia64 from invoking irq handlers on
offline CPUs) removed the call to cpu_clear() before we call
migrate_platform_irqs().
Thus, if migrate_platform_irqs() fails (returns -EBUSY), we do
not need to re-set our CPU in the cpu_online_map, since it was
never cleared.
Remove the redundant call and cleanup the resulting stylistic
fallout.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
Tony, unlike my previous patch, this patch is .30 material,
thanks.
---
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
index 1146399..92fe9cf 100644
--- a/arch/ia64/kernel/smpboot.c
+++ b/arch/ia64/kernel/smpboot.c
@@ -736,10 +736,8 @@ int __cpu_disable(void)
return -EBUSY;
}
- if (migrate_platform_irqs(cpu)) {
- cpu_set(cpu, cpu_online_map);
- return (-EBUSY);
- }
+ if (migrate_platform_irqs(cpu))
+ return -EBUSY;
remove_siblinginfo(cpu);
fixup_irqs();
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-02-06 16:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-06 16:49 [PATCH] ia64: don't need cpu_set() when migrate_platform_irqs() Alex Chiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox