* [PATCH] ia64: Fix kernel BUG at lib/ioremap.c:72!
[not found] <CAK8P3a0Jk_Q-9c7PizRF4HteigfiOprRszpaV9SCk-6tUYfVVQ@mail.gmail.com>
@ 2018-08-20 16:31 ` Tony Luck
2018-08-20 19:23 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Tony Luck @ 2018-08-20 16:31 UTC (permalink / raw)
To: Linus Torvalds
Cc: Tony Luck, linux-ia64, Linux Kernel Mailing List, Arnd Bergmann,
Boris Brezillon, Bjorn Helgaas, Sinan Kaya, Tomasz Nowicki,
Lorenzo Pieralisi, Miquel Raynal
Commit:
0bbf47eab469 ("ia64: use asm-generic/io.h")
results in a BUG while booting ia64. This is because
asm-generic/io.h defines PCI_IOBASE, which results in
the function acpi_pci_root_remap_iospace() doing a lot
of unnecessary (and wrong) things.
I'd suggested an #if !CONFIG_IA64 in the functon, but Arnd
suggested keeping the fix inside the arch/ia64 tree.
Fixes: 0bbf47eab469 ("ia64: use asm-generic/io.h")
Suggested-by: Arnd Bergman <arnd@arndb.de>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
arch/ia64/include/asm/io.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/ia64/include/asm/io.h b/arch/ia64/include/asm/io.h
index 6f952171abf9..1e6fef69bb01 100644
--- a/arch/ia64/include/asm/io.h
+++ b/arch/ia64/include/asm/io.h
@@ -454,6 +454,7 @@ extern void memset_io(volatile void __iomem *s, int c, long n);
#define xlate_dev_kmem_ptr xlate_dev_kmem_ptr
#define xlate_dev_mem_ptr xlate_dev_mem_ptr
#include <asm-generic/io.h>
+#undef PCI_IOBASE
# endif /* __KERNEL__ */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ia64: Fix kernel BUG at lib/ioremap.c:72!
2018-08-20 16:31 ` [PATCH] ia64: Fix kernel BUG at lib/ioremap.c:72! Tony Luck
@ 2018-08-20 19:23 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2018-08-20 19:23 UTC (permalink / raw)
To: Tony Luck
Cc: linux-ia64@vger.kernel.org, Linux Kernel Mailing List,
Arnd Bergmann, boris.brezillon, Bjorn Helgaas, Sinan Kaya, tn,
Lorenzo Pieralisi, miquel.raynal
On Mon, Aug 20, 2018 at 9:31 AM Tony Luck <tony.luck@intel.com> wrote:
> I'd suggested an #if !CONFIG_IA64 in the functon, but Arnd
> suggested keeping the fix inside the arch/ia64 tree.
>
> Fixes: 0bbf47eab469 ("ia64: use asm-generic/io.h")
Applied.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-20 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAK8P3a0Jk_Q-9c7PizRF4HteigfiOprRszpaV9SCk-6tUYfVVQ@mail.gmail.com>
2018-08-20 16:31 ` [PATCH] ia64: Fix kernel BUG at lib/ioremap.c:72! Tony Luck
2018-08-20 19:23 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox