* Re: [PATCH] ia64: fix build failure caused by memory model changes
2020-12-18 16:35 [PATCH] ia64: fix build failure caused by memory model changes Mike Rapoport
@ 2020-12-18 17:19 ` Guenter Roeck
2021-01-14 12:57 ` Mike Rapoport
2021-01-14 12:58 ` Mike Rapoport
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-12-18 17:19 UTC (permalink / raw)
To: Mike Rapoport
Cc: Andrew Morton, Mike Rapoport, Tony Luck, linux-ia64, linux-kernel
On Fri, Dec 18, 2020 at 06:35:50PM +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> The change of ia64's default memory model to SPARSEMEM causes defconfig
> build to fail:
>
> CC kernel/async.o
> In file included from include/linux/numa.h:25,
> from include/linux/async.h:13,
> from kernel/async.c:47:
> arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
> 14 | #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS)
> | ^~~~~~~~~~
> In file included from include/linux/gfp.h:6,
> from include/linux/xarray.h:14,
> from include/linux/radix-tree.h:19,
> from include/linux/idr.h:15,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:16,
> from include/linux/kobject.h:20,
> from include/linux/energy_model.h:7,
> from include/linux/device.h:16,
> from include/linux/async.h:14,
> from kernel/async.c:47:
> include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE
> 1156 | #error Allocator MAX_ORDER exceeds SECTION_SIZE
> | ^~~~~
>
> The error cause is the missing definition of PAGE_SHIFT in the calculation
> of SECTION_SIZE_BITS.
>
> Add include of <asm/page.h> to arch/ia64/include/asm/sparsemem.h to solve
> the problem.
>
> Fixes: 214496cb1870 ("ia64: make SPARSEMEM default and disable DISCONTIGMEM")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Surprisingly, only Guenter's bot caught this.
>
> @Andrew, if you prefer I can take this via memblock tree.
>
> arch/ia64/include/asm/sparsemem.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/ia64/include/asm/sparsemem.h b/arch/ia64/include/asm/sparsemem.h
> index dd8c166ffd7b..42ed5248fae9 100644
> --- a/arch/ia64/include/asm/sparsemem.h
> +++ b/arch/ia64/include/asm/sparsemem.h
> @@ -3,6 +3,7 @@
> #define _ASM_IA64_SPARSEMEM_H
>
> #ifdef CONFIG_SPARSEMEM
> +#include <asm/page.h>
> /*
> * SECTION_SIZE_BITS 2^N: how big each section will be
> * MAX_PHYSMEM_BITS 2^N: how much memory we can have in that space
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ia64: fix build failure caused by memory model changes
2020-12-18 16:35 [PATCH] ia64: fix build failure caused by memory model changes Mike Rapoport
2020-12-18 17:19 ` Guenter Roeck
@ 2021-01-14 12:57 ` Mike Rapoport
2021-01-14 12:58 ` Mike Rapoport
2 siblings, 0 replies; 4+ messages in thread
From: Mike Rapoport @ 2021-01-14 12:57 UTC (permalink / raw)
To: Tony Luck
Cc: Andrew Morton, Guenter Roeck, Mike Rapoport, linux-ia64,
linux-kernel
Andrew,
Would you like me to
On Fri, Dec 18, 2020 at 06:35:50PM +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> The change of ia64's default memory model to SPARSEMEM causes defconfig
> build to fail:
>
> CC kernel/async.o
> In file included from include/linux/numa.h:25,
> from include/linux/async.h:13,
> from kernel/async.c:47:
> arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
> 14 | #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS)
> | ^~~~~~~~~~
> In file included from include/linux/gfp.h:6,
> from include/linux/xarray.h:14,
> from include/linux/radix-tree.h:19,
> from include/linux/idr.h:15,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:16,
> from include/linux/kobject.h:20,
> from include/linux/energy_model.h:7,
> from include/linux/device.h:16,
> from include/linux/async.h:14,
> from kernel/async.c:47:
> include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE
> 1156 | #error Allocator MAX_ORDER exceeds SECTION_SIZE
> | ^~~~~
>
> The error cause is the missing definition of PAGE_SHIFT in the calculation
> of SECTION_SIZE_BITS.
>
> Add include of <asm/page.h> to arch/ia64/include/asm/sparsemem.h to solve
> the problem.
>
> Fixes: 214496cb1870 ("ia64: make SPARSEMEM default and disable DISCONTIGMEM")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
>
> Surprisingly, only Guenter's bot caught this.
>
> @Andrew, if you prefer I can take this via memblock tree.
>
> arch/ia64/include/asm/sparsemem.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/ia64/include/asm/sparsemem.h b/arch/ia64/include/asm/sparsemem.h
> index dd8c166ffd7b..42ed5248fae9 100644
> --- a/arch/ia64/include/asm/sparsemem.h
> +++ b/arch/ia64/include/asm/sparsemem.h
> @@ -3,6 +3,7 @@
> #define _ASM_IA64_SPARSEMEM_H
>
> #ifdef CONFIG_SPARSEMEM
> +#include <asm/page.h>
> /*
> * SECTION_SIZE_BITS 2^N: how big each section will be
> * MAX_PHYSMEM_BITS 2^N: how much memory we can have in that space
> --
> 2.28.0
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ia64: fix build failure caused by memory model changes
2020-12-18 16:35 [PATCH] ia64: fix build failure caused by memory model changes Mike Rapoport
2020-12-18 17:19 ` Guenter Roeck
2021-01-14 12:57 ` Mike Rapoport
@ 2021-01-14 12:58 ` Mike Rapoport
2 siblings, 0 replies; 4+ messages in thread
From: Mike Rapoport @ 2021-01-14 12:58 UTC (permalink / raw)
To: Andrew Morton
Cc: Guenter Roeck, Mike Rapoport, Tony Luck, linux-ia64, linux-kernel
If there are no objections, I'll take it via the memblock tree.
@Tony an ack would be appreciated.
On Fri, Dec 18, 2020 at 06:35:50PM +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> The change of ia64's default memory model to SPARSEMEM causes defconfig
> build to fail:
>
> CC kernel/async.o
> In file included from include/linux/numa.h:25,
> from include/linux/async.h:13,
> from kernel/async.c:47:
> arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined, evaluates to 0 [-Wundef]
> 14 | #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS)
> | ^~~~~~~~~~
> In file included from include/linux/gfp.h:6,
> from include/linux/xarray.h:14,
> from include/linux/radix-tree.h:19,
> from include/linux/idr.h:15,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:16,
> from include/linux/kobject.h:20,
> from include/linux/energy_model.h:7,
> from include/linux/device.h:16,
> from include/linux/async.h:14,
> from kernel/async.c:47:
> include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE
> 1156 | #error Allocator MAX_ORDER exceeds SECTION_SIZE
> | ^~~~~
>
> The error cause is the missing definition of PAGE_SHIFT in the calculation
> of SECTION_SIZE_BITS.
>
> Add include of <asm/page.h> to arch/ia64/include/asm/sparsemem.h to solve
> the problem.
>
> Fixes: 214496cb1870 ("ia64: make SPARSEMEM default and disable DISCONTIGMEM")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
>
> Surprisingly, only Guenter's bot caught this.
>
> @Andrew, if you prefer I can take this via memblock tree.
>
> arch/ia64/include/asm/sparsemem.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/ia64/include/asm/sparsemem.h b/arch/ia64/include/asm/sparsemem.h
> index dd8c166ffd7b..42ed5248fae9 100644
> --- a/arch/ia64/include/asm/sparsemem.h
> +++ b/arch/ia64/include/asm/sparsemem.h
> @@ -3,6 +3,7 @@
> #define _ASM_IA64_SPARSEMEM_H
>
> #ifdef CONFIG_SPARSEMEM
> +#include <asm/page.h>
> /*
> * SECTION_SIZE_BITS 2^N: how big each section will be
> * MAX_PHYSMEM_BITS 2^N: how much memory we can have in that space
> --
> 2.28.0
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread