* Re: [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK
2021-09-26 17:12 [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK Randy Dunlap
@ 2021-09-27 3:22 ` Paul Gortmaker
2021-09-27 4:53 ` Randy Dunlap
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Paul Gortmaker @ 2021-09-27 3:22 UTC (permalink / raw)
To: linux-ia64
[[PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK] On 26/09/2021 (Sun 10:12) Randy Dunlap wrote:
> When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
> _printk(), but _printk() is a static inline function, not available
> as an extern.
> Since the purpose of the macro is to print the BUGCHECK info,
> make this config option depend on PRINTK.
>
> Fixes multiple occurrences of this build error:
>
> ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
> 208 | int _printk(const char *s, ...)
> | ^~~~~~~
> In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
> ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
> 146 | extern int _printk(const char *fmt, ...);
>
> Fixes: 85f8f7759e41 ("ia64: populate the cmpxchg header with appropriate code")
I don't think this fixes tag makes sense either as it was just a
straightforward code relocation. As pointed out elsewhere, it will
probably be back even further where CONFIG_PRINTK was introduced, which
would be d59745ce3e7a (2005 vintage). The ia64 debug option predates
git, so it isn't at fault (and you can't blame it anyway).
Honestly, realize this is just for a randconfig for ia64 where PRINTK is
disabled - something that will never be done in any of the remaining
ia64 deployments out there (if there is any). So I'd just recommend
dropping the Fixes tag and move on. It isn't like there is a lot of
people out there doing randconfig builds on linux-stable releases.
Paul.
--
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: linux-ia64@vger.kernel.org
> Cc: Petr Mladek <pmladek@suse.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Chris Down <chris@chrisdown.name>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> ---
> v2: correct the Fixes: commit info
>
> arch/ia64/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210917.orig/arch/ia64/Kconfig.debug
> +++ linux-next-20210917/arch/ia64/Kconfig.debug
> @@ -39,7 +39,7 @@ config DISABLE_VHPT
>
> config IA64_DEBUG_CMPXCHG
> bool "Turn on compare-and-exchange bug checking (slow!)"
> - depends on DEBUG_KERNEL
> + depends on DEBUG_KERNEL && PRINTK
> help
> Selecting this option turns on bug checking for the IA-64
> compare-and-exchange instructions. This is slow! Itaniums
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK
2021-09-26 17:12 [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK Randy Dunlap
2021-09-27 3:22 ` Paul Gortmaker
@ 2021-09-27 4:53 ` Randy Dunlap
2021-09-27 11:15 ` Petr Mladek
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-09-27 4:53 UTC (permalink / raw)
To: linux-ia64
On 9/26/21 8:22 PM, Paul Gortmaker wrote:
> [[PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK] On 26/09/2021 (Sun 10:12) Randy Dunlap wrote:
>
>> When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
>> _printk(), but _printk() is a static inline function, not available
>> as an extern.
>> Since the purpose of the macro is to print the BUGCHECK info,
>> make this config option depend on PRINTK.
>>
>> Fixes multiple occurrences of this build error:
>>
>> ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
>> 208 | int _printk(const char *s, ...)
>> | ^~~~~~~
>> In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
>> ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
>> 146 | extern int _printk(const char *fmt, ...);
>>
>> Fixes: 85f8f7759e41 ("ia64: populate the cmpxchg header with appropriate code")
>
> I don't think this fixes tag makes sense either as it was just a
> straightforward code relocation. As pointed out elsewhere, it will
> probably be back even further where CONFIG_PRINTK was introduced, which
> would be d59745ce3e7a (2005 vintage). The ia64 debug option predates
> git, so it isn't at fault (and you can't blame it anyway).
>
> Honestly, realize this is just for a randconfig for ia64 where PRINTK is
> disabled - something that will never be done in any of the remaining
> ia64 deployments out there (if there is any). So I'd just recommend
> dropping the Fixes tag and move on. It isn't like there is a lot of
> people out there doing randconfig builds on linux-stable releases.
>
Yes, I like the idea of dropping the Fixes: tag also. Thanks.
Guess I'll send a v3.
> --
>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: linux-ia64@vger.kernel.org
>> Cc: Petr Mladek <pmladek@suse.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Tony Luck <tony.luck@intel.com>
>> Cc: Chris Down <chris@chrisdown.name>
>> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> ---
>> v2: correct the Fixes: commit info
>>
>> arch/ia64/Kconfig.debug | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20210917.orig/arch/ia64/Kconfig.debug
>> +++ linux-next-20210917/arch/ia64/Kconfig.debug
>> @@ -39,7 +39,7 @@ config DISABLE_VHPT
>>
>> config IA64_DEBUG_CMPXCHG
>> bool "Turn on compare-and-exchange bug checking (slow!)"
>> - depends on DEBUG_KERNEL
>> + depends on DEBUG_KERNEL && PRINTK
>> help
>> Selecting this option turns on bug checking for the IA-64
>> compare-and-exchange instructions. This is slow! Itaniums
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK
2021-09-26 17:12 [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK Randy Dunlap
2021-09-27 3:22 ` Paul Gortmaker
2021-09-27 4:53 ` Randy Dunlap
@ 2021-09-27 11:15 ` Petr Mladek
2021-09-27 18:57 ` Randy Dunlap
2021-10-04 9:23 ` Petr Mladek
4 siblings, 0 replies; 6+ messages in thread
From: Petr Mladek @ 2021-09-27 11:15 UTC (permalink / raw)
To: linux-ia64
On Sun 2021-09-26 21:53:33, Randy Dunlap wrote:
> On 9/26/21 8:22 PM, Paul Gortmaker wrote:
> > [[PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK] On 26/09/2021 (Sun 10:12) Randy Dunlap wrote:
> >
> > > When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
> > > _printk(), but _printk() is a static inline function, not available
> > > as an extern.
> > > Since the purpose of the macro is to print the BUGCHECK info,
> > > make this config option depend on PRINTK.
> > >
> > > Fixes multiple occurrences of this build error:
> > >
> > > ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
> > > 208 | int _printk(const char *s, ...)
> > > | ^~~~~~~
> > > In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
> > > ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
> > > 146 | extern int _printk(const char *fmt, ...);
> > >
> > > Fixes: 85f8f7759e41 ("ia64: populate the cmpxchg header with appropriate code")
> >
> > I don't think this fixes tag makes sense either as it was just a
> > straightforward code relocation. As pointed out elsewhere, it will
> > probably be back even further where CONFIG_PRINTK was introduced, which
> > would be d59745ce3e7a (2005 vintage). The ia64 debug option predates
> > git, so it isn't at fault (and you can't blame it anyway).
> >
> > Honestly, realize this is just for a randconfig for ia64 where PRINTK is
> > disabled - something that will never be done in any of the remaining
> > ia64 deployments out there (if there is any). So I'd just recommend
> > dropping the Fixes tag and move on. It isn't like there is a lot of
> > people out there doing randconfig builds on linux-stable releases.
> >
>
> Yes, I like the idea of dropping the Fixes: tag also. Thanks.
> Guess I'll send a v3.
I could take it via printk tree. I am going to wait 2-3 more days
just in case anyone has a comment.
Feel free to send v3 but I could just remove the tag when pushing v2.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK
2021-09-26 17:12 [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK Randy Dunlap
` (2 preceding siblings ...)
2021-09-27 11:15 ` Petr Mladek
@ 2021-09-27 18:57 ` Randy Dunlap
2021-10-04 9:23 ` Petr Mladek
4 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-09-27 18:57 UTC (permalink / raw)
To: linux-ia64
On 9/27/21 4:15 AM, Petr Mladek wrote:
> On Sun 2021-09-26 21:53:33, Randy Dunlap wrote:
>> On 9/26/21 8:22 PM, Paul Gortmaker wrote:
>>> [[PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK] On 26/09/2021 (Sun 10:12) Randy Dunlap wrote:
>>>
>>>> When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
>>>> _printk(), but _printk() is a static inline function, not available
>>>> as an extern.
>>>> Since the purpose of the macro is to print the BUGCHECK info,
>>>> make this config option depend on PRINTK.
>>>>
>>>> Fixes multiple occurrences of this build error:
>>>>
>>>> ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
>>>> 208 | int _printk(const char *s, ...)
>>>> | ^~~~~~~
>>>> In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
>>>> ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
>>>> 146 | extern int _printk(const char *fmt, ...);
>>>>
>>>> Fixes: 85f8f7759e41 ("ia64: populate the cmpxchg header with appropriate code")
>>>
>>> I don't think this fixes tag makes sense either as it was just a
>>> straightforward code relocation. As pointed out elsewhere, it will
>>> probably be back even further where CONFIG_PRINTK was introduced, which
>>> would be d59745ce3e7a (2005 vintage). The ia64 debug option predates
>>> git, so it isn't at fault (and you can't blame it anyway).
>>>
>>> Honestly, realize this is just for a randconfig for ia64 where PRINTK is
>>> disabled - something that will never be done in any of the remaining
>>> ia64 deployments out there (if there is any). So I'd just recommend
>>> dropping the Fixes tag and move on. It isn't like there is a lot of
>>> people out there doing randconfig builds on linux-stable releases.
>>>
>>
>> Yes, I like the idea of dropping the Fixes: tag also. Thanks.
>> Guess I'll send a v3.
>
> I could take it via printk tree. I am going to wait 2-3 more days
> just in case anyone has a comment.
>
> Feel free to send v3 but I could just remove the tag when pushing v2.
Hi Petr,
Please just remove the Fixes: tag after waiting a few more days
for comments.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK
2021-09-26 17:12 [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK Randy Dunlap
` (3 preceding siblings ...)
2021-09-27 18:57 ` Randy Dunlap
@ 2021-10-04 9:23 ` Petr Mladek
4 siblings, 0 replies; 6+ messages in thread
From: Petr Mladek @ 2021-10-04 9:23 UTC (permalink / raw)
To: linux-ia64
On Mon 2021-09-27 11:57:18, Randy Dunlap wrote:
> On 9/27/21 4:15 AM, Petr Mladek wrote:
> > On Sun 2021-09-26 21:53:33, Randy Dunlap wrote:
> > > On 9/26/21 8:22 PM, Paul Gortmaker wrote:
> > > > [[PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK] On 26/09/2021 (Sun 10:12) Randy Dunlap wrote:
> > > >
> > > > > When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
> > > > > _printk(), but _printk() is a static inline function, not available
> > > > > as an extern.
> > > > > Since the purpose of the macro is to print the BUGCHECK info,
> > > > > make this config option depend on PRINTK.
> > > > >
> > > > > Fixes multiple occurrences of this build error:
> > > > >
> > > > > ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
> > > > > 208 | int _printk(const char *s, ...)
> > > > > | ^~~~~~~
> > > > > In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
> > > > > ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
> > > > > 146 | extern int _printk(const char *fmt, ...);
> > > > >
> > > > > Fixes: 85f8f7759e41 ("ia64: populate the cmpxchg header with appropriate code")
> > > >
> > > > I don't think this fixes tag makes sense either as it was just a
> > > > straightforward code relocation. As pointed out elsewhere, it will
> > > > probably be back even further where CONFIG_PRINTK was introduced, which
> > > > would be d59745ce3e7a (2005 vintage). The ia64 debug option predates
> > > > git, so it isn't at fault (and you can't blame it anyway).
> > > >
> > > > Honestly, realize this is just for a randconfig for ia64 where PRINTK is
> > > > disabled - something that will never be done in any of the remaining
> > > > ia64 deployments out there (if there is any). So I'd just recommend
> > > > dropping the Fixes tag and move on. It isn't like there is a lot of
> > > > people out there doing randconfig builds on linux-stable releases.
> > > >
> > >
> > > Yes, I like the idea of dropping the Fixes: tag also. Thanks.
> > > Guess I'll send a v3.
> >
> > I could take it via printk tree. I am going to wait 2-3 more days
> > just in case anyone has a comment.
> >
> > Feel free to send v3 but I could just remove the tag when pushing v2.
>
> Hi Petr,
>
> Please just remove the Fixes: tag after waiting a few more days
> for comments.
Done. The patch has been pushed into printk/linux.git, branch
for-5.16.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 6+ messages in thread