* [PATCH 12/22] ia64: cleanup remove_siblinginfo()
[not found] <20220510154750.212913-1-yury.norov@gmail.com>
@ 2022-05-10 15:47 ` Yury Norov
2022-05-10 22:33 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Yury Norov @ 2022-05-10 15:47 UTC (permalink / raw)
To: Andy Shevchenko, David Laight, Greg Kroah-Hartman, Joe Perches,
Julia Lawall, Michał Mirosław, Nicholas Piggin,
Nicolas Palix, Peter Zijlstra, Rasmus Villemoes, Matti Vaittinen,
linux-kernel
Cc: Yury Norov, Ingo Molnar, Valentin Schneider, linux-ia64
remove_siblinginfo() initialises variable 'last', but never uses it.
Drop unneeded code.
CC: Ingo Molnar <mingo@kernel.org>
CC: Peter Zijlstra <peterz@infradead.org>
CC: Valentin Schneider <vschneid@redhat.com>
CC: linux-ia64@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
arch/ia64/kernel/smpboot.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
index d10f780c13b9..d0e935cf2093 100644
--- a/arch/ia64/kernel/smpboot.c
+++ b/arch/ia64/kernel/smpboot.c
@@ -576,8 +576,6 @@ clear_cpu_sibling_map(int cpu)
static void
remove_siblinginfo(int cpu)
{
- int last = 0;
-
if (cpu_data(cpu)->threads_per_core = 1 &&
cpu_data(cpu)->cores_per_socket = 1) {
cpumask_clear_cpu(cpu, &cpu_core_map[cpu]);
@@ -585,8 +583,6 @@ remove_siblinginfo(int cpu)
return;
}
- last = (cpumask_weight(&cpu_core_map[cpu]) = 1 ? 1 : 0);
-
/* remove it from all sibling map's */
clear_cpu_sibling_map(cpu);
}
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 12/22] ia64: cleanup remove_siblinginfo()
2022-05-10 15:47 ` [PATCH 12/22] ia64: cleanup remove_siblinginfo() Yury Norov
@ 2022-05-10 22:33 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2022-05-10 22:33 UTC (permalink / raw)
To: Yury Norov
Cc: Andy Shevchenko, David Laight, Greg Kroah-Hartman, Joe Perches,
Julia Lawall, Michał Mirosław, Nicholas Piggin,
Nicolas Palix, Peter Zijlstra, Rasmus Villemoes, Matti Vaittinen,
linux-kernel, Ingo Molnar, Valentin Schneider, linux-ia64
On Tue, 10 May 2022 08:47:40 -0700 Yury Norov <yury.norov@gmail.com> wrote:
> remove_siblinginfo() initialises variable 'last', but never uses it.
> Drop unneeded code.
ack. I'll assume you'll be merging this up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-10 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220510154750.212913-1-yury.norov@gmail.com>
2022-05-10 15:47 ` [PATCH 12/22] ia64: cleanup remove_siblinginfo() Yury Norov
2022-05-10 22:33 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox