public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Joshua Aas <josha@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: clean up comments in arch/ia64/mm/init.c
Date: Wed, 14 Jul 2004 22:06:44 +0000	[thread overview]
Message-ID: <40F5AE74.10308@sgi.com> (raw)

While working on another patch in arch/ia64/mm/init.c, I found a comment that doesn't seem to make sense and one that just has a minor whitespace problem. The problem with the comment after setup_gate() is that boot memory seems to have already been freed a few lines earlier in the function and nothing else happens in mem_init() after the call to setup_gate() (unless compiling for IA32).

If there aren't any objections, it would be nice to have this patch applied so as not to confuse people in the future.

Signed-off-by: Josh Aas <josha@sgi.com>

----------------------------------------
--- a/arch/ia64/mm/init.c    2004-06-16 00:19:22.000000000 -0500
+++ b/arch/ia64/mm/init.c       2004-07-14 16:50:59.000000000 -0500
@@ -169,7 +169,7 @@ free_initrd_mem (unsigned long start, un
 {
        struct page *page;
        /*
-        * EFI uses 4KB pages while the kernel can use 4KB  or bigger.
+        * EFI uses 4KB pages while the kernel can use 4KB or bigger.
         * Thus EFI and the kernel may have different page sizes. It is
         * therefore possible to have the initrd share the same page as
         * the end of the kernel (given current setup).
@@ -580,7 +580,7 @@ mem_init (void)
                if (!fsyscall_table[i] || nolwsys)
                        fsyscall_table[i] = sys_call_table[i] | 1;
        }
-       setup_gate();   /* setup gate pages before we free up boot memory... */
+       setup_gate();
 
 #ifdef CONFIG_IA32_SUPPORT
        ia32_boot_gdt_init();

----------------------------------------

-- 
Josh Aas
Silicon Graphics, Inc. (SGI)
Linux System Software
651-683-3068

             reply	other threads:[~2004-07-14 22:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-14 22:06 Joshua Aas [this message]
2004-07-14 23:32 ` clean up comments in arch/ia64/mm/init.c David Mosberger
2004-07-15 14:39 ` Joshua Aas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40F5AE74.10308@sgi.com \
    --to=josha@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox