From: Joshua Aas <josha@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: clean up comments in arch/ia64/mm/init.c
Date: Thu, 15 Jul 2004 14:39:36 +0000 [thread overview]
Message-ID: <40F69728.6080002@sgi.com> (raw)
In-Reply-To: <40F5AE74.10308@sgi.com>
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
David Mosberger wrote:
>>>>>>On Wed, 14 Jul 2004 17:06:44 -0500, Joshua Aas <josha@sgi.com> said:
>
>
> Joshua> While working on another patch in arch/ia64/mm/init.c, I
> Joshua> found a comment that doesn't seem to make sense and one that
> Joshua> just has a minor whitespace problem. The problem with the
> Joshua> comment after setup_gate() is that boot memory seems to have
> Joshua> already been freed a few lines earlier in the function and
> Joshua> nothing else happens in mem_init() after the call to
> Joshua> setup_gate() (unless compiling for IA32). If there aren't
> Joshua> any objections, it would be nice to have this patch applied
> Joshua> so as not to confuse people in the future.
>
> -EPATCHDOESNTAPPLY.
>
> I think your mailer mangles whitespace. Try sending it as a MIME
> attachement.
>
> --david
Patch is attached.
Signed-off-by: Josh Aas <josha@sgi.com>
--
Josh Aas
Silicon Graphics, Inc. (SGI)
Linux System Software
651-683-3068
[-- Attachment #2: init.c.comments.patch --]
[-- Type: text/x-patch, Size: 792 bytes --]
--- a/arch/ia64/mm/init.c 2004-06-16 00:19:22.000000000 -0500
+++ b/arch/ia64/mm/init.c 2004-07-14 16:50:59.000000000 -0500
@@ -169,7 +169,7 @@ free_initrd_mem (unsigned long start, un
{
struct page *page;
/*
- * EFI uses 4KB pages while the kernel can use 4KB or bigger.
+ * EFI uses 4KB pages while the kernel can use 4KB or bigger.
* Thus EFI and the kernel may have different page sizes. It is
* therefore possible to have the initrd share the same page as
* the end of the kernel (given current setup).
@@ -580,7 +580,7 @@ mem_init (void)
if (!fsyscall_table[i] || nolwsys)
fsyscall_table[i] = sys_call_table[i] | 1;
}
- setup_gate(); /* setup gate pages before we free up boot memory... */
+ setup_gate();
#ifdef CONFIG_IA32_SUPPORT
ia32_boot_gdt_init();
prev parent reply other threads:[~2004-07-15 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 22:06 clean up comments in arch/ia64/mm/init.c Joshua Aas
2004-07-14 23:32 ` David Mosberger
2004-07-15 14:39 ` Joshua Aas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F69728.6080002@sgi.com \
--to=josha@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox