From: Arun Sharma <arun.sharma@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] add BUG call to overlapping vma fix
Date: Fri, 14 Jan 2005 23:36:13 +0000 [thread overview]
Message-ID: <41E8576D.9060802@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0501141131310.12942-200000@dhcp83-105.boston.redhat.com>
On 1/14/2005 8:52 AM, Jason Baron wrote:
> hi,
>
> It seems that in ia64_elf32_init, instead of calling return, if we insert
> an overlapping vma, we should instead BUG(). We should never get into this
> code path, because the vma's are set above PAGE_OFFSET, and thus a
> Xmalicious user can not trigger this code path. This change is being
> suggested mainly for clarity. Thanks to Stephen Tweedie for pointing out
> that returning early in ia64_elf32_init could have unpredictable results.
>
Couldn't you get rid of a couple of more lines before the BUG()? Otherwise, the patch looks good to me.
-Arun
next prev parent reply other threads:[~2005-01-14 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 16:52 [patch] add BUG call to overlapping vma fix Jason Baron
2005-01-14 23:36 ` Arun Sharma [this message]
2005-01-17 18:32 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E8576D.9060802@intel.com \
--to=arun.sharma@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox