* [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP
@ 2006-12-19 21:04 akpm
2006-12-20 9:27 ` Jes Sorensen
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: akpm @ 2006-12-19 21:04 UTC (permalink / raw)
To: linux-ia64
From: Andrew Morton <akpm@osdl.org>
Some trivial bugs are coming from ia64 developers. Try to help them.
Cc: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
arch/ia64/configs/bigsur_defconfig | 2 +-
arch/ia64/configs/gensparse_defconfig | 2 +-
arch/ia64/configs/sim_defconfig | 2 +-
arch/ia64/configs/sn2_defconfig | 2 +-
arch/ia64/configs/tiger_defconfig | 4 ++--
arch/ia64/configs/zx1_defconfig | 2 +-
arch/ia64/defconfig | 2 +-
7 files changed, 8 insertions(+), 8 deletions(-)
diff -puN arch/ia64/configs/bigsur_defconfig~ia64-enable-config_debug_spinlock_sleep arch/ia64/configs/bigsur_defconfig
--- a/arch/ia64/configs/bigsur_defconfig~ia64-enable-config_debug_spinlock_sleep
+++ a/arch/ia64/configs/bigsur_defconfig
@@ -1305,7 +1305,7 @@ CONFIG_DETECT_SOFTLOCKUP=y
CONFIG_DEBUG_PREEMPT=y
CONFIG_DEBUG_MUTEXES=y
# CONFIG_DEBUG_SPINLOCK is not set
-# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
+CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_KOBJECT is not set
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_FS is not set
diff -puN arch/ia64/configs/sim_defconfig~ia64-enable-config_debug_spinlock_sleep arch/ia64/configs/sim_defconfig
--- a/arch/ia64/configs/sim_defconfig~ia64-enable-config_debug_spinlock_sleep
+++ a/arch/ia64/configs/sim_defconfig
@@ -694,7 +694,7 @@ CONFIG_DETECT_SOFTLOCKUP=y
CONFIG_DEBUG_PREEMPT=y
CONFIG_DEBUG_MUTEXES=y
# CONFIG_DEBUG_SPINLOCK is not set
-# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
+CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_KOBJECT is not set
CONFIG_DEBUG_INFO=y
# CONFIG_DEBUG_FS is not set
diff -puN arch/ia64/configs/sn2_defconfig~ia64-enable-config_debug_spinlock_sleep arch/ia64/configs/sn2_defconfig
--- a/arch/ia64/configs/sn2_defconfig~ia64-enable-config_debug_spinlock_sleep
+++ a/arch/ia64/configs/sn2_defconfig
@@ -1284,7 +1284,7 @@ CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_DEBUG_MUTEXES is not set
# CONFIG_DEBUG_RWSEMS is not set
-# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
+CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set
# CONFIG_DEBUG_KOBJECT is not set
CONFIG_DEBUG_INFO=y
diff -puN arch/ia64/configs/tiger_defconfig~ia64-enable-config_debug_spinlock_sleep arch/ia64/configs/tiger_defconfig
--- a/arch/ia64/configs/tiger_defconfig~ia64-enable-config_debug_spinlock_sleep
+++ a/arch/ia64/configs/tiger_defconfig
@@ -1,4 +1,4 @@
-#
+;#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.16-rc5
# Mon Feb 27 15:49:18 2006
@@ -1190,7 +1190,7 @@ CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_DEBUG_SLAB is not set
CONFIG_DEBUG_MUTEXES=y
# CONFIG_DEBUG_SPINLOCK is not set
-# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
+CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_KOBJECT is not set
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_FS is not set
diff -puN arch/ia64/configs/zx1_defconfig~ia64-enable-config_debug_spinlock_sleep arch/ia64/configs/zx1_defconfig
--- a/arch/ia64/configs/zx1_defconfig~ia64-enable-config_debug_spinlock_sleep
+++ a/arch/ia64/configs/zx1_defconfig
@@ -1359,7 +1359,7 @@ CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_DEBUG_SLAB is not set
CONFIG_DEBUG_MUTEXES=y
# CONFIG_DEBUG_SPINLOCK is not set
-# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
+CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_KOBJECT is not set
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_FS is not set
diff -puN arch/ia64/configs/gensparse_defconfig~ia64-enable-config_debug_spinlock_sleep arch/ia64/configs/gensparse_defconfig
--- a/arch/ia64/configs/gensparse_defconfig~ia64-enable-config_debug_spinlock_sleep
+++ a/arch/ia64/configs/gensparse_defconfig
@@ -1339,7 +1339,7 @@ CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_DEBUG_SLAB is not set
CONFIG_DEBUG_MUTEXES=y
# CONFIG_DEBUG_SPINLOCK is not set
-# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
+CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_KOBJECT is not set
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_FS is not set
diff -puN arch/ia64/defconfig~ia64-enable-config_debug_spinlock_sleep arch/ia64/defconfig
--- a/arch/ia64/defconfig~ia64-enable-config_debug_spinlock_sleep
+++ a/arch/ia64/defconfig
@@ -1339,7 +1339,7 @@ CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_DEBUG_SLAB is not set
CONFIG_DEBUG_MUTEXES=y
# CONFIG_DEBUG_SPINLOCK is not set
-# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
+CONFIG_DEBUG_SPINLOCK_SLEEP=y
# CONFIG_DEBUG_KOBJECT is not set
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_FS is not set
_
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP
2006-12-19 21:04 [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP akpm
@ 2006-12-20 9:27 ` Jes Sorensen
2006-12-20 9:38 ` Andrew Morton
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jes Sorensen @ 2006-12-20 9:27 UTC (permalink / raw)
To: linux-ia64
>>>>> "Andrew" = akpm <akpm@osdl.org> writes:
Andrew> From: Andrew Morton <akpm@osdl.org> Some trivial bugs are
Andrew> coming from ia64 developers. Try to help them.
Ugh!
Please don't do this in the sn2 defconfig! Spin lock debugging totally
kills scalability. I'll end up with a ton of internal complaints over
the kernel not performing if this goes in :-(
Cheers,
Jes
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP
2006-12-19 21:04 [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP akpm
2006-12-20 9:27 ` Jes Sorensen
@ 2006-12-20 9:38 ` Andrew Morton
2006-12-20 9:46 ` Jes Sorensen
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2006-12-20 9:38 UTC (permalink / raw)
To: linux-ia64
On 20 Dec 2006 04:27:11 -0500
Jes Sorensen <jes@sgi.com> wrote:
> >>>>> "Andrew" = akpm <akpm@osdl.org> writes:
>
> Andrew> From: Andrew Morton <akpm@osdl.org> Some trivial bugs are
> Andrew> coming from ia64 developers. Try to help them.
>
> Ugh!
>
> Please don't do this in the sn2 defconfig! Spin lock debugging totally
> kills scalability. I'll end up with a ton of internal complaints over
> the kernel not performing if this goes in :-(
Well you tell me how to stop ia64 developers from submitting stuff which
has stupid bugs which instamanifest for everyone else? It is not uncommon.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP
2006-12-19 21:04 [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP akpm
2006-12-20 9:27 ` Jes Sorensen
2006-12-20 9:38 ` Andrew Morton
@ 2006-12-20 9:46 ` Jes Sorensen
2006-12-20 9:53 ` Andrew Morton
2006-12-20 9:56 ` Jes Sorensen
4 siblings, 0 replies; 6+ messages in thread
From: Jes Sorensen @ 2006-12-20 9:46 UTC (permalink / raw)
To: linux-ia64
Andrew Morton wrote:
>> Please don't do this in the sn2 defconfig! Spin lock debugging totally
>> kills scalability. I'll end up with a ton of internal complaints over
>> the kernel not performing if this goes in :-(
>
> Well you tell me how to stop ia64 developers from submitting stuff which
> has stupid bugs which instamanifest for everyone else? It is not uncommon.
Beat them with a stick?
Seriously, not sure how to deal with it. I try and keep the
sn2_defconfig to match the actual hardware and my colleagues rely on
being able to build that. With spin lock debugging enabled we can barely
boot the system on medium to large boxes.
If you get stuff like that from someone with an sgi.com address, let me
know and I'll apply the clue 2x4.
Cheers,
Jes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP
2006-12-19 21:04 [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP akpm
` (2 preceding siblings ...)
2006-12-20 9:46 ` Jes Sorensen
@ 2006-12-20 9:53 ` Andrew Morton
2006-12-20 9:56 ` Jes Sorensen
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2006-12-20 9:53 UTC (permalink / raw)
To: linux-ia64
On Wed, 20 Dec 2006 10:46:40 +0100
Jes Sorensen <jes@sgi.com> wrote:
> Andrew Morton wrote:
> >> Please don't do this in the sn2 defconfig! Spin lock debugging totally
> >> kills scalability. I'll end up with a ton of internal complaints over
> >> the kernel not performing if this goes in :-(
> >
> > Well you tell me how to stop ia64 developers from submitting stuff which
> > has stupid bugs which instamanifest for everyone else? It is not uncommon.
>
> Beat them with a stick?
Make it a pointy stick and I can improve on that.
I've been thinking that we could do with a CONFIG_RC_KERNEL or something
which gets turned on up until -rc4 or so, then gets turned off. So we can
make the devel kernels more debugging-friendly.
The main problem would be remembering to turn the dang thing off and on at
the right times.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP
2006-12-19 21:04 [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP akpm
` (3 preceding siblings ...)
2006-12-20 9:53 ` Andrew Morton
@ 2006-12-20 9:56 ` Jes Sorensen
4 siblings, 0 replies; 6+ messages in thread
From: Jes Sorensen @ 2006-12-20 9:56 UTC (permalink / raw)
To: linux-ia64
Andrew Morton wrote:
> Make it a pointy stick and I can improve on that.
Aye! aye! sir!
> I've been thinking that we could do with a CONFIG_RC_KERNEL or something
> which gets turned on up until -rc4 or so, then gets turned off. So we can
> make the devel kernels more debugging-friendly.
>
> The main problem would be remembering to turn the dang thing off and on at
> the right times.
I like that idea! I wonder if we could somehow do this with some script
magic? but we may also want to be able to offer it as a config option
that people can force off if they want to (with some flashy neon signs
telling them they are entering rogue territory).
Cheers,
Jes
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-12-20 9:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-19 21:04 [patch 1/3] ia64: enable CONFIG_DEBUG_SPINLOCK_SLEEP akpm
2006-12-20 9:27 ` Jes Sorensen
2006-12-20 9:38 ` Andrew Morton
2006-12-20 9:46 ` Jes Sorensen
2006-12-20 9:53 ` Andrew Morton
2006-12-20 9:56 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox