* [PATCH] Remove always-true tests in irq handlers
[not found] <9799624f63e093aa915947aea8fb1b8a5df959a1.1193390973.git.jeff@garzik.org>
@ 2007-10-26 9:40 ` Jeff Garzik
2007-10-26 12:02 ` Ralf Baechle
2007-10-26 9:40 ` [PATCH] IA64, PPC, SPARC: minor irq handler cleanups Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-10-26 9:40 UTC (permalink / raw)
To: LKML; +Cc: akpm, tony.luck, linux-ia64, netdev, ralf
In these drivers, dev_id is always non-NULL.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/ia64/hp/sim/simeth.c | 5 -----
arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c | 5 +----
drivers/net/cpmac.c | 3 ---
drivers/net/ucc_geth.c | 3 ---
drivers/net/wan/farsync.c | 11 +++--------
5 files changed, 4 insertions(+), 23 deletions(-)
diff --git a/arch/ia64/hp/sim/simeth.c b/arch/ia64/hp/sim/simeth.c
index 08b117e..9898feb 100644
--- a/arch/ia64/hp/sim/simeth.c
+++ b/arch/ia64/hp/sim/simeth.c
@@ -497,11 +497,6 @@ simeth_interrupt(int irq, void *dev_id)
{
struct net_device *dev = dev_id;
- if ( dev = NULL ) {
- printk(KERN_WARNING "simeth: irq %d for unknown device\n", irq);
- return IRQ_NONE;
- }
-
/*
* very simple loop because we get interrupts only when receiving
*/
diff --git a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
index ab96a2d..11769b5 100644
--- a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
+++ b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
@@ -126,9 +126,6 @@ static irqreturn_t hwbutton_handler(int irq, void *data)
struct hwbutton_interrupt *hirq = data;
unsigned long cic_ext = *CIC_EXT_CFG_REG;
- if (irq != hirq->irq)
- return IRQ_NONE;
-
if (CIC_EXT_IS_ACTIVE_HI(cic_ext, hirq->eirq)) {
/* Interrupt: pin is now HI */
CIC_EXT_SET_ACTIVE_LO(cic_ext, hirq->eirq);
@@ -164,7 +161,7 @@ static int msp_hwbutton_register(struct hwbutton_interrupt *hirq)
*CIC_EXT_CFG_REG = cic_ext;
return request_irq(hirq->irq, hwbutton_handler, IRQF_DISABLED,
- hirq->name, (void *)hirq);
+ hirq->name, hirq);
}
static int __init msp_hwbutton_setup(void)
diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c
index 6fd95a2..91d1596 100644
--- a/drivers/net/cpmac.c
+++ b/drivers/net/cpmac.c
@@ -661,9 +661,6 @@ static irqreturn_t cpmac_irq(int irq, void *dev_id)
int queue;
u32 status;
- if (!dev)
- return IRQ_NONE;
-
priv = netdev_priv(dev);
status = cpmac_read(priv->regs, CPMAC_MAC_INT_VECTOR);
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 9741d61..2243d34 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -3621,9 +3621,6 @@ static irqreturn_t ucc_geth_irq_handler(int irq, void *info)
ugeth_vdbg("%s: IN", __FUNCTION__);
- if (!ugeth)
- return IRQ_NONE;
-
uccf = ugeth->uccf;
ug_info = ugeth->ug_info;
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 12dae8e..cf27bf4 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -1498,9 +1498,9 @@ do_bottom_half_rx(struct fst_card_info *card)
* Dev_id is our fst_card_info pointer
*/
static irqreturn_t
-fst_intr(int irq, void *dev_id)
+fst_intr(int dummy, void *dev_id)
{
- struct fst_card_info *card;
+ struct fst_card_info *card = dev_id;
struct fst_port_info *port;
int rdidx; /* Event buffer indices */
int wridx;
@@ -1509,17 +1509,12 @@ fst_intr(int irq, void *dev_id)
unsigned int do_card_interrupt;
unsigned int int_retry_count;
- if ((card = dev_id) = NULL) {
- dbg(DBG_INTR, "intr: spurious %d\n", irq);
- return IRQ_NONE;
- }
-
/*
* Check to see if the interrupt was for this card
* return if not
* Note that the call to clear the interrupt is important
*/
- dbg(DBG_INTR, "intr: %d %p\n", irq, card);
+ dbg(DBG_INTR, "intr: %d %p\n", card->irq, card);
if (card->state != FST_RUNNING) {
printk_err
("Interrupt received for card %d in a non running state (%d)\n",
--
1.5.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] IA64, PPC, SPARC: minor irq handler cleanups
[not found] <9799624f63e093aa915947aea8fb1b8a5df959a1.1193390973.git.jeff@garzik.org>
2007-10-26 9:40 ` [PATCH] Remove always-true tests in irq handlers Jeff Garzik
@ 2007-10-26 9:40 ` Jeff Garzik
2007-10-26 9:44 ` Kumar Gala
1 sibling, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-10-26 9:40 UTC (permalink / raw)
To: LKML; +Cc: akpm, davem, tony.luck, linux-ia64, paulus, benh, galak
ia64/sn/kernel/huberror.c:
- remove pointless void* cast
- add KERN_xxx prefix
ia64/sn/pci/tioce_provider.c: start functions at column zero
ppc/8xx_io/fec.c: kill prototype, remove extra whitespace
ppc/platforms/85xx/*
'irq' argument in irq handler is used purely as a temporary
variable. Update the function to reflect this usage, changing
the first arg's name from 'irq' to 'dummy'
ppc/platforms/sbc82xx.c: ditto
sparc/kernel/time.c: mark timer_interrupt() static (from DaveM)
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/ia64/sn/kernel/huberror.c | 4 ++--
arch/ia64/sn/pci/tioce_provider.c | 6 ++++--
arch/ppc/8xx_io/fec.c | 3 +--
arch/ppc/platforms/85xx/mpc8560_ads.c | 4 +++-
arch/ppc/platforms/85xx/mpc85xx_cds_common.c | 4 +++-
arch/ppc/platforms/85xx/stx_gp3.c | 4 +++-
arch/ppc/platforms/85xx/tqm85xx.c | 4 +++-
arch/ppc/platforms/sbc82xx.c | 4 +++-
arch/sparc/kernel/time.c | 2 +-
9 files changed, 23 insertions(+), 12 deletions(-)
diff --git a/arch/ia64/sn/kernel/huberror.c b/arch/ia64/sn/kernel/huberror.c
index b663168..fc217c3 100644
--- a/arch/ia64/sn/kernel/huberror.c
+++ b/arch/ia64/sn/kernel/huberror.c
@@ -187,8 +187,8 @@ void hub_error_init(struct hubdev_info *hubdev_info)
{
if (request_irq(SGI_II_ERROR, hub_eint_handler, IRQF_SHARED,
- "SN_hub_error", (void *)hubdev_info)) {
- printk("hub_error_init: Failed to request_irq for 0x%p\n",
+ "SN_hub_error", hubdev_info)) {
+ printk(KERN_ERR "hub_error_init: Failed to request_irq for 0x%p\n",
hubdev_info);
return;
}
diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
index cee9379..714d6df 100644
--- a/arch/ia64/sn/pci/tioce_provider.c
+++ b/arch/ia64/sn/pci/tioce_provider.c
@@ -655,7 +655,8 @@ tioce_dma(struct pci_dev *pdev, u64 paddr, size_t byte_count, int dma_flags)
*
* Simply call tioce_do_dma_map() to create a map with the barrier bit set
* in the address.
- */ static u64
+ */
+static u64
tioce_dma_consistent(struct pci_dev *pdev, u64 paddr, size_t byte_count, int dma_flags)
{
return tioce_do_dma_map(pdev, paddr, byte_count, 1, dma_flags);
@@ -668,7 +669,8 @@ tioce_dma_consistent(struct pci_dev *pdev, u64 paddr, size_t byte_count, int dma
*
* Handle a CE error interrupt. Simply a wrapper around a SAL call which
* defers processing to the SGI prom.
- */ static irqreturn_t
+ */
+static irqreturn_t
tioce_error_intr_handler(int irq, void *arg)
{
struct tioce_common *soft = arg;
diff --git a/arch/ppc/8xx_io/fec.c b/arch/ppc/8xx_io/fec.c
index 0288279..b31897d 100644
--- a/arch/ppc/8xx_io/fec.c
+++ b/arch/ppc/8xx_io/fec.c
@@ -199,7 +199,6 @@ static int fec_enet_start_xmit(struct sk_buff *skb, struct net_device *dev);
#ifdef CONFIG_USE_MDIO
static void fec_enet_mii(struct net_device *dev);
#endif /* CONFIG_USE_MDIO */
-static irqreturn_t fec_enet_interrupt(int irq, void * dev_id);
#ifdef CONFIG_FEC_PACKETHOOK
static void fec_enet_tx(struct net_device *dev, __u32 regval);
static void fec_enet_rx(struct net_device *dev, __u32 regval);
@@ -472,7 +471,7 @@ fec_timeout(struct net_device *dev)
* This is called from the MPC core interrupt.
*/
static irqreturn_t
-fec_enet_interrupt(int irq, void * dev_id)
+fec_enet_interrupt(int irq, void *dev_id)
{
struct net_device *dev = dev_id;
volatile fec_t *fecp;
diff --git a/arch/ppc/platforms/85xx/mpc8560_ads.c b/arch/ppc/platforms/85xx/mpc8560_ads.c
index 3a06046..9426293 100644
--- a/arch/ppc/platforms/85xx/mpc8560_ads.c
+++ b/arch/ppc/platforms/85xx/mpc8560_ads.c
@@ -211,8 +211,10 @@ mpc8560ads_setup_arch(void)
#endif
}
-static irqreturn_t cpm2_cascade(int irq, void *dev_id)
+static irqreturn_t cpm2_cascade(int dummy, void *dev_id)
{
+ int irq;
+
while ((irq = cpm2_get_irq()) >= 0)
__do_IRQ(irq);
return IRQ_HANDLED;
diff --git a/arch/ppc/platforms/85xx/mpc85xx_cds_common.c b/arch/ppc/platforms/85xx/mpc85xx_cds_common.c
index 2d59eb7..791fef0 100644
--- a/arch/ppc/platforms/85xx/mpc85xx_cds_common.c
+++ b/arch/ppc/platforms/85xx/mpc85xx_cds_common.c
@@ -127,8 +127,10 @@ mpc85xx_cds_show_cpuinfo(struct seq_file *m)
}
#ifdef CONFIG_CPM2
-static irqreturn_t cpm2_cascade(int irq, void *dev_id)
+static irqreturn_t cpm2_cascade(int dummy, void *dev_id)
{
+ int irq;
+
while((irq = cpm2_get_irq()) >= 0)
__do_IRQ(irq);
return IRQ_HANDLED;
diff --git a/arch/ppc/platforms/85xx/stx_gp3.c b/arch/ppc/platforms/85xx/stx_gp3.c
index b1f5b73..7444f85 100644
--- a/arch/ppc/platforms/85xx/stx_gp3.c
+++ b/arch/ppc/platforms/85xx/stx_gp3.c
@@ -156,8 +156,10 @@ gp3_setup_arch(void)
printk ("bi_immr_base = %8.8lx\n", binfo->bi_immr_base);
}
-static irqreturn_t cpm2_cascade(int irq, void *dev_id)
+static irqreturn_t cpm2_cascade(int dummy, void *dev_id)
{
+ int irq;
+
while ((irq = cpm2_get_irq()) >= 0)
__do_IRQ(irq);
diff --git a/arch/ppc/platforms/85xx/tqm85xx.c b/arch/ppc/platforms/85xx/tqm85xx.c
index 4ee2bd1..61e3429 100644
--- a/arch/ppc/platforms/85xx/tqm85xx.c
+++ b/arch/ppc/platforms/85xx/tqm85xx.c
@@ -181,8 +181,10 @@ tqm85xx_setup_arch(void)
}
#ifdef CONFIG_MPC8560
-static irqreturn_t cpm2_cascade(int irq, void *dev_id)
+static irqreturn_t cpm2_cascade(int dummy, void *dev_id)
{
+ int irq;
+
while ((irq = cpm2_get_irq()) >= 0)
__do_IRQ(irq);
return IRQ_HANDLED;
diff --git a/arch/ppc/platforms/sbc82xx.c b/arch/ppc/platforms/sbc82xx.c
index cc0935c..0df6aac 100644
--- a/arch/ppc/platforms/sbc82xx.c
+++ b/arch/ppc/platforms/sbc82xx.c
@@ -121,8 +121,10 @@ struct hw_interrupt_type sbc82xx_i8259_ic = {
.end = sbc82xx_i8259_end_irq,
};
-static irqreturn_t sbc82xx_i8259_demux(int irq, void *dev_id)
+static irqreturn_t sbc82xx_i8259_demux(int dummy, void *dev_id)
{
+ int irq;
+
spin_lock(&sbc82xx_i8259_lock);
sbc82xx_i8259_map[0] = 0x0c; /* OCW3: Read IR register on RD# pulse */
diff --git a/arch/sparc/kernel/time.c b/arch/sparc/kernel/time.c
index 4bf78a5..2f4e61d 100644
--- a/arch/sparc/kernel/time.c
+++ b/arch/sparc/kernel/time.c
@@ -106,7 +106,7 @@ __volatile__ unsigned int *master_l10_limit;
#define TICK_SIZE (tick_nsec / 1000)
-irqreturn_t timer_interrupt(int irq, void *dev_id)
+static irqreturn_t timer_interrupt(int dummy, void *dev_id)
{
/* last time the cmos clock got updated */
static long last_rtc_update;
--
1.5.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] IA64, PPC, SPARC: minor irq handler cleanups
2007-10-26 9:40 ` [PATCH] IA64, PPC, SPARC: minor irq handler cleanups Jeff Garzik
@ 2007-10-26 9:44 ` Kumar Gala
2007-10-26 9:49 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Kumar Gala @ 2007-10-26 9:44 UTC (permalink / raw)
To: Jeff Garzik; +Cc: LKML, akpm, davem, tony.luck, linux-ia64, paulus, benh
On Oct 26, 2007, at 4:40 AM, Jeff Garzik wrote:
> ia64/sn/kernel/huberror.c:
> - remove pointless void* cast
> - add KERN_xxx prefix
>
> ia64/sn/pci/tioce_provider.c: start functions at column zero
>
> ppc/8xx_io/fec.c: kill prototype, remove extra whitespace
>
> ppc/platforms/85xx/*
> 'irq' argument in irq handler is used purely as a temporary
> variable. Update the function to reflect this usage, changing
> the first arg's name from 'irq' to 'dummy'
>
> ppc/platforms/sbc82xx.c: ditto
>
> sparc/kernel/time.c: mark timer_interrupt() static (from DaveM)
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
> arch/ia64/sn/kernel/huberror.c | 4 ++--
> arch/ia64/sn/pci/tioce_provider.c | 6 ++++--
> arch/ppc/8xx_io/fec.c | 3 +--
> arch/ppc/platforms/85xx/mpc8560_ads.c | 4 +++-
> arch/ppc/platforms/85xx/mpc85xx_cds_common.c | 4 +++-
> arch/ppc/platforms/85xx/stx_gp3.c | 4 +++-
> arch/ppc/platforms/85xx/tqm85xx.c | 4 +++-
> arch/ppc/platforms/sbc82xx.c | 4 +++-
> arch/sparc/kernel/time.c | 2 +-
> 9 files changed, 23 insertions(+), 12 deletions(-)
I haven't been following this with detail. Is the intent that this
would be for 2.6.24 or .25?
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IA64, PPC, SPARC: minor irq handler cleanups
2007-10-26 9:44 ` Kumar Gala
@ 2007-10-26 9:49 ` Jeff Garzik
2007-10-26 14:55 ` Kumar Gala
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-10-26 9:49 UTC (permalink / raw)
To: Kumar Gala; +Cc: LKML, akpm, davem, tony.luck, linux-ia64, paulus, benh
Kumar Gala wrote:
>
> On Oct 26, 2007, at 4:40 AM, Jeff Garzik wrote:
>
>> ia64/sn/kernel/huberror.c:
>> - remove pointless void* cast
>> - add KERN_xxx prefix
>>
>> ia64/sn/pci/tioce_provider.c: start functions at column zero
>>
>> ppc/8xx_io/fec.c: kill prototype, remove extra whitespace
>>
>> ppc/platforms/85xx/*
>> 'irq' argument in irq handler is used purely as a temporary
>> variable. Update the function to reflect this usage, changing
>> the first arg's name from 'irq' to 'dummy'
>>
>> ppc/platforms/sbc82xx.c: ditto
>>
>> sparc/kernel/time.c: mark timer_interrupt() static (from DaveM)
>>
>> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
>> ---
>> arch/ia64/sn/kernel/huberror.c | 4 ++--
>> arch/ia64/sn/pci/tioce_provider.c | 6 ++++--
>> arch/ppc/8xx_io/fec.c | 3 +--
>> arch/ppc/platforms/85xx/mpc8560_ads.c | 4 +++-
>> arch/ppc/platforms/85xx/mpc85xx_cds_common.c | 4 +++-
>> arch/ppc/platforms/85xx/stx_gp3.c | 4 +++-
>> arch/ppc/platforms/85xx/tqm85xx.c | 4 +++-
>> arch/ppc/platforms/sbc82xx.c | 4 +++-
>> arch/sparc/kernel/time.c | 2 +-
>> 9 files changed, 23 insertions(+), 12 deletions(-)
>
> I haven't been following this with detail. Is the intent that this
> would be for 2.6.24 or .25?
These patches are all cleanups and minor fixes I found while iterating
through each interrupt handler in the kernel, in pursuit of a related
project.
So they can stand by themselves, and can integrate into whatever flow
maintainers find most comfortable.
I'm not in any rush, but neither would I like them to sit forever...
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove always-true tests in irq handlers
2007-10-26 9:40 ` [PATCH] Remove always-true tests in irq handlers Jeff Garzik
@ 2007-10-26 12:02 ` Ralf Baechle
0 siblings, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2007-10-26 12:02 UTC (permalink / raw)
To: Jeff Garzik; +Cc: LKML, akpm, tony.luck, linux-ia64, netdev
On Fri, Oct 26, 2007 at 05:40:24AM -0400, Jeff Garzik wrote:
> In these drivers, dev_id is always non-NULL.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
> arch/ia64/hp/sim/simeth.c | 5 -----
> arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c | 5 +----
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] IA64, PPC, SPARC: minor irq handler cleanups
2007-10-26 9:49 ` Jeff Garzik
@ 2007-10-26 14:55 ` Kumar Gala
0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2007-10-26 14:55 UTC (permalink / raw)
To: Jeff Garzik; +Cc: LKML, akpm, davem, tony.luck, linux-ia64, paulus, benh
On Oct 26, 2007, at 4:49 AM, Jeff Garzik wrote:
> Kumar Gala wrote:
>> On Oct 26, 2007, at 4:40 AM, Jeff Garzik wrote:
>>> ia64/sn/kernel/huberror.c:
>>> - remove pointless void* cast
>>> - add KERN_xxx prefix
>>>
>>> ia64/sn/pci/tioce_provider.c: start functions at column zero
>>>
>>> ppc/8xx_io/fec.c: kill prototype, remove extra whitespace
>>>
>>> ppc/platforms/85xx/*
>>> 'irq' argument in irq handler is used purely as a temporary
>>> variable. Update the function to reflect this usage, changing
>>> the first arg's name from 'irq' to 'dummy'
>>>
>>> ppc/platforms/sbc82xx.c: ditto
>>>
>>> sparc/kernel/time.c: mark timer_interrupt() static (from DaveM)
>>>
>>> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
>>> ---
>>> arch/ia64/sn/kernel/huberror.c | 4 ++--
>>> arch/ia64/sn/pci/tioce_provider.c | 6 ++++--
>>> arch/ppc/8xx_io/fec.c | 3 +--
>>> arch/ppc/platforms/85xx/mpc8560_ads.c | 4 +++-
>>> arch/ppc/platforms/85xx/mpc85xx_cds_common.c | 4 +++-
>>> arch/ppc/platforms/85xx/stx_gp3.c | 4 +++-
>>> arch/ppc/platforms/85xx/tqm85xx.c | 4 +++-
>>> arch/ppc/platforms/sbc82xx.c | 4 +++-
>>> arch/sparc/kernel/time.c | 2 +-
>>> 9 files changed, 23 insertions(+), 12 deletions(-)
>> I haven't been following this with detail. Is the intent that
>> this would be for 2.6.24 or .25?
>
> These patches are all cleanups and minor fixes I found while
> iterating through each interrupt handler in the kernel, in pursuit
> of a related project.
>
> So they can stand by themselves, and can integrate into whatever
> flow maintainers find most comfortable.
>
> I'm not in any rush, but neither would I like them to sit forever...
Ok. Not to be a pain, but it would be easier if this one patch might
be easier if it was split down the arch lines so each maintainer can
deal with it.
I say this especially for the ppc code because the intent in 2.6.25
is to actually try and remove some of the files you are fixing up for
their arch/powerpc variants.
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-10-26 14:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <9799624f63e093aa915947aea8fb1b8a5df959a1.1193390973.git.jeff@garzik.org>
2007-10-26 9:40 ` [PATCH] Remove always-true tests in irq handlers Jeff Garzik
2007-10-26 12:02 ` Ralf Baechle
2007-10-26 9:40 ` [PATCH] IA64, PPC, SPARC: minor irq handler cleanups Jeff Garzik
2007-10-26 9:44 ` Kumar Gala
2007-10-26 9:49 ` Jeff Garzik
2007-10-26 14:55 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox