* [PATCH 2/6] IA64: fix memset size error
@ 2007-11-05 2:17 Li Zefan
2007-11-05 2:20 ` Li Zefan
2007-11-05 3:23 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Li Zefan @ 2007-11-05 2:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, tony.luck, linux-ia64
The size arguments passing to memset is wrong.
Signed-off-by Li Zefan <lizf@cn.fujitsu.com>
---
drivers/video/ps3fb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
index b3463dd..75836aa 100644
--- a/drivers/video/ps3fb.c
+++ b/drivers/video/ps3fb.c
@@ -727,7 +727,7 @@ static int ps3fb_blank(int blank, struct fb_info *info)
static int ps3fb_get_vblank(struct fb_vblank *vblank)
{
- memset(vblank, 0, sizeof(&vblank));
+ memset(vblank, 0, sizeof(*vblank));
vblank->flags = FB_VBLANK_HAVE_VSYNC;
return 0;
}
--
1.5.3.rc7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/6] IA64: fix memset size error
2007-11-05 2:17 [PATCH 2/6] IA64: fix memset size error Li Zefan
@ 2007-11-05 2:20 ` Li Zefan
2007-11-05 3:23 ` Simon Horman
2007-11-05 3:23 ` Simon Horman
1 sibling, 1 reply; 4+ messages in thread
From: Li Zefan @ 2007-11-05 2:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, tony.luck, linux-ia64
Li Zefan wrote:
> The size arguments passing to memset is wrong.
>
> Signed-off-by Li Zefan <lizf@cn.fujitsu.com>
>
> ---
> drivers/video/ps3fb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Sorry, please ignore the wrong patch, and here is the right one:
---
arch/ia64/kernel/efi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
index 3f7ea13..0e4ef20 100644
--- a/arch/ia64/kernel/efi.c
+++ b/arch/ia64/kernel/efi.c
@@ -218,7 +218,7 @@ efi_gettimeofday (struct timespec *ts)
{
efi_time_t tm;
- memset(ts, 0, sizeof(ts));
+ memset(ts, 0, sizeof(*ts));
if ((*efi.get_time)(&tm, NULL) != EFI_SUCCESS)
return;
--
1.5.3.rc7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/6] IA64: fix memset size error
2007-11-05 2:17 [PATCH 2/6] IA64: fix memset size error Li Zefan
2007-11-05 2:20 ` Li Zefan
@ 2007-11-05 3:23 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2007-11-05 3:23 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, LKML, tony.luck, linux-ia64
On Mon, Nov 05, 2007 at 10:17:24AM +0800, Li Zefan wrote:
> The size arguments passing to memset is wrong.
>
> Signed-off-by Li Zefan <lizf@cn.fujitsu.com>
This looks correct to me. Acked.
> ---
> drivers/video/ps3fb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
> index b3463dd..75836aa 100644
> --- a/drivers/video/ps3fb.c
> +++ b/drivers/video/ps3fb.c
> @@ -727,7 +727,7 @@ static int ps3fb_blank(int blank, struct fb_info *info)
>
> static int ps3fb_get_vblank(struct fb_vblank *vblank)
> {
> - memset(vblank, 0, sizeof(&vblank));
> + memset(vblank, 0, sizeof(*vblank));
> vblank->flags = FB_VBLANK_HAVE_VSYNC;
> return 0;
> }
> --
> 1.5.3.rc7
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/6] IA64: fix memset size error
2007-11-05 2:20 ` Li Zefan
@ 2007-11-05 3:23 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2007-11-05 3:23 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, LKML, tony.luck, linux-ia64
On Mon, Nov 05, 2007 at 10:20:12AM +0800, Li Zefan wrote:
> Li Zefan wrote:
> > The size arguments passing to memset is wrong.
> >
> > Signed-off-by Li Zefan <lizf@cn.fujitsu.com>
This looks correct to me. Acked.
> >
> > ---
> > drivers/video/ps3fb.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
>
> Sorry, please ignore the wrong patch, and here is the right one:
>
> ---
> arch/ia64/kernel/efi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
> index 3f7ea13..0e4ef20 100644
> --- a/arch/ia64/kernel/efi.c
> +++ b/arch/ia64/kernel/efi.c
> @@ -218,7 +218,7 @@ efi_gettimeofday (struct timespec *ts)
> {
> efi_time_t tm;
>
> - memset(ts, 0, sizeof(ts));
> + memset(ts, 0, sizeof(*ts));
> if ((*efi.get_time)(&tm, NULL) != EFI_SUCCESS)
> return;
>
> --
> 1.5.3.rc7
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-05 3:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-05 2:17 [PATCH 2/6] IA64: fix memset size error Li Zefan
2007-11-05 2:20 ` Li Zefan
2007-11-05 3:23 ` Simon Horman
2007-11-05 3:23 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox