* Re: [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary
2008-04-09 4:50 [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support Isaku Yamahata
@ 2008-04-09 5:09 ` Jeremy Fitzhardinge
2008-04-09 9:01 ` [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support Isaku Yamahata
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2008-04-09 5:09 UTC (permalink / raw)
To: linux-ia64
Isaku Yamahata wrote:
> define sync bitops which is necessary for ia64/xen.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
> include/asm-ia64/sync_bitops.h | 59 ++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 59 insertions(+), 0 deletions(-)
> create mode 100644 include/asm-ia64/sync_bitops.h
>
> diff --git a/include/asm-ia64/sync_bitops.h b/include/asm-ia64/sync_bitops.h
> new file mode 100644
> index 0000000..f56cd90
> --- /dev/null
> +++ b/include/asm-ia64/sync_bitops.h
> @@ -0,0 +1,59 @@
> +#ifndef _ASM_IA64_SYNC_BITOPS_H
> +#define _ASM_IA64_SYNC_BITOPS_H
> +
> +/*
> + * Copyright 1992, Linus Torvalds.
> + * Heavily modified to provide guaranteed strong synchronisation
> + * when communicating with Xen or other guest OSes running on other CPUs.
> + */
> +
> +static inline void sync_set_bit(int nr, volatile void *addr)
> +{
> + set_bit(nr, addr);
> +}
> +
> +static inline void sync_clear_bit(int nr, volatile void *addr)
> +{
> + clear_bit(nr, addr);
> +}
> +
> +static inline void sync_change_bit(int nr, volatile void *addr)
> +{
> + change_bit(nr, addr);
> +}
> +
> +static inline int sync_test_and_set_bit(int nr, volatile void *addr)
> +{
> + return test_and_set_bit(nr, addr);
> +}
> +
> +static inline int sync_test_and_clear_bit(int nr, volatile void *addr)
> +{
> + return test_and_clear_bit(nr, addr);
> +}
> +
> +static inline int sync_test_and_change_bit(int nr, volatile void *addr)
> +{
> + return test_and_change_bit(nr, addr);
> +}
> +
> +static inline int sync_const_test_bit(int nr, const volatile void *addr)
> +{
> + return test_bit(nr, addr);
> +}
> +
> +static inline int sync_var_test_bit(int nr, volatile void *addr)
> +{
> + return test_bit(nr, addr);
> +}
> +
> +#define sync_cmpxchg ia64_cmpxchg4_acq
>
Please always use arguments with function-like macros, to prevent
accidental namespace clashes.
> +
> +#define sync_test_bit(nr,addr) \
> + (__builtin_constant_p(nr) ? \
> + sync_const_test_bit((nr), (addr)) : \
> + sync_var_test_bit((nr), (addr)))
> +
> +#define sync_cmpxchg_subword sync_cmpxchg
>
Ditto.
J
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support.
2008-04-09 4:50 [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support Isaku Yamahata
2008-04-09 5:09 ` [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary Jeremy Fitzhardinge
@ 2008-04-09 9:01 ` Isaku Yamahata
2008-04-30 12:30 ` Isaku Yamahata
2008-05-19 23:07 ` Isaku Yamahata
3 siblings, 0 replies; 5+ messages in thread
From: Isaku Yamahata @ 2008-04-09 9:01 UTC (permalink / raw)
To: linux-ia64
On Wed, Apr 09, 2008 at 12:09:51AM -0500, Jeremy Fitzhardinge wrote:
> >+#define sync_cmpxchg ia64_cmpxchg4_acq
> >
>
> Please always use arguments with function-like macros, to prevent
> accidental namespace clashes.
Will fix.
> >+#define sync_cmpxchg_subword sync_cmpxchg
> >
>
> Ditto.
It looks like that sync_cmpxchg_subword isn't used any more.
Is it safe to eliminate sync_cmpxchg_subword?
--
yamahata
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support.
2008-04-09 4:50 [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support Isaku Yamahata
2008-04-09 5:09 ` [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary Jeremy Fitzhardinge
2008-04-09 9:01 ` [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support Isaku Yamahata
@ 2008-04-30 12:30 ` Isaku Yamahata
2008-05-19 23:07 ` Isaku Yamahata
3 siblings, 0 replies; 5+ messages in thread
From: Isaku Yamahata @ 2008-04-30 12:30 UTC (permalink / raw)
To: linux-ia64
define sync bitops which is necessary for ia64/xen.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
include/asm-ia64/sync_bitops.h | 57 ++++++++++++++++++++++++++++++++++++++++
1 files changed, 57 insertions(+), 0 deletions(-)
create mode 100644 include/asm-ia64/sync_bitops.h
diff --git a/include/asm-ia64/sync_bitops.h b/include/asm-ia64/sync_bitops.h
new file mode 100644
index 0000000..27dc777
--- /dev/null
+++ b/include/asm-ia64/sync_bitops.h
@@ -0,0 +1,57 @@
+#ifndef _ASM_IA64_SYNC_BITOPS_H
+#define _ASM_IA64_SYNC_BITOPS_H
+
+/*
+ * Copyright 1992, Linus Torvalds.
+ * Heavily modified to provide guaranteed strong synchronisation
+ * when communicating with Xen or other guest OSes running on other CPUs.
+ */
+
+static inline void sync_set_bit(int nr, volatile void *addr)
+{
+ set_bit(nr, addr);
+}
+
+static inline void sync_clear_bit(int nr, volatile void *addr)
+{
+ clear_bit(nr, addr);
+}
+
+static inline void sync_change_bit(int nr, volatile void *addr)
+{
+ change_bit(nr, addr);
+}
+
+static inline int sync_test_and_set_bit(int nr, volatile void *addr)
+{
+ return test_and_set_bit(nr, addr);
+}
+
+static inline int sync_test_and_clear_bit(int nr, volatile void *addr)
+{
+ return test_and_clear_bit(nr, addr);
+}
+
+static inline int sync_test_and_change_bit(int nr, volatile void *addr)
+{
+ return test_and_change_bit(nr, addr);
+}
+
+static inline int sync_const_test_bit(int nr, const volatile void *addr)
+{
+ return test_bit(nr, addr);
+}
+
+static inline int sync_var_test_bit(int nr, volatile void *addr)
+{
+ return test_bit(nr, addr);
+}
+
+#define sync_cmpxchg(ptr, old, new) cmpxchg_acq((ptr), (old), (new))
+
+#define sync_test_bit(nr,addr) \
+ (__builtin_constant_p(nr) ? \
+ sync_const_test_bit((nr), (addr)) : \
+ sync_var_test_bit((nr), (addr)))
+
+#endif /* _ASM_IA64_SYNC_BITOPS_H */
--
1.5.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support.
2008-04-09 4:50 [PATCH 01/23] ia64/xen: introduce synch bitops which is necessary for ia64/xen support Isaku Yamahata
` (2 preceding siblings ...)
2008-04-30 12:30 ` Isaku Yamahata
@ 2008-05-19 23:07 ` Isaku Yamahata
3 siblings, 0 replies; 5+ messages in thread
From: Isaku Yamahata @ 2008-05-19 23:07 UTC (permalink / raw)
To: linux-ia64
define sync bitops which is necessary for ia64/xen.
Cc: Robin Holt <holt@sgi.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
include/asm-ia64/sync_bitops.h | 57 ++++++++++++++++++++++++++++++++++++++++
1 files changed, 57 insertions(+), 0 deletions(-)
create mode 100644 include/asm-ia64/sync_bitops.h
diff --git a/include/asm-ia64/sync_bitops.h b/include/asm-ia64/sync_bitops.h
new file mode 100644
index 0000000..27dc777
--- /dev/null
+++ b/include/asm-ia64/sync_bitops.h
@@ -0,0 +1,57 @@
+#ifndef _ASM_IA64_SYNC_BITOPS_H
+#define _ASM_IA64_SYNC_BITOPS_H
+
+/*
+ * Copyright 1992, Linus Torvalds.
+ * Heavily modified to provide guaranteed strong synchronisation
+ * when communicating with Xen or other guest OSes running on other CPUs.
+ */
+
+static inline void sync_set_bit(int nr, volatile void *addr)
+{
+ set_bit(nr, addr);
+}
+
+static inline void sync_clear_bit(int nr, volatile void *addr)
+{
+ clear_bit(nr, addr);
+}
+
+static inline void sync_change_bit(int nr, volatile void *addr)
+{
+ change_bit(nr, addr);
+}
+
+static inline int sync_test_and_set_bit(int nr, volatile void *addr)
+{
+ return test_and_set_bit(nr, addr);
+}
+
+static inline int sync_test_and_clear_bit(int nr, volatile void *addr)
+{
+ return test_and_clear_bit(nr, addr);
+}
+
+static inline int sync_test_and_change_bit(int nr, volatile void *addr)
+{
+ return test_and_change_bit(nr, addr);
+}
+
+static inline int sync_const_test_bit(int nr, const volatile void *addr)
+{
+ return test_bit(nr, addr);
+}
+
+static inline int sync_var_test_bit(int nr, volatile void *addr)
+{
+ return test_bit(nr, addr);
+}
+
+#define sync_cmpxchg(ptr, old, new) cmpxchg_acq((ptr), (old), (new))
+
+#define sync_test_bit(nr,addr) \
+ (__builtin_constant_p(nr) ? \
+ sync_const_test_bit((nr), (addr)) : \
+ sync_var_test_bit((nr), (addr)))
+
+#endif /* _ASM_IA64_SYNC_BITOPS_H */
--
1.5.3
^ permalink raw reply related [flat|nested] 5+ messages in thread