From: Jes Sorensen <jes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [patch] fix zero extending for mmio ld1/2/4 emulation in KVM
Date: Tue, 20 May 2008 09:57:58 +0000 [thread overview]
Message-ID: <4832A0A6.8050800@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
Hi,
This one seems to solve the problem I have been seeing with ld2.acq
not being zero extended under KVM.
I believe this patch is correct - please shoot me if I am wrong.
Cheers,
Jes
[-- Attachment #2: mmio-zero-extend.diff --]
[-- Type: text/plain, Size: 834 bytes --]
Only copy in the data actually requested by the instruction emulation
and zero pad the destination register first. This avoids the problem
where emulated mmio access got garbled data from ld2.acq instructions
in the vga console driver.
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
arch/ia64/kvm/mmio.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Index: linux-2.6.git/arch/ia64/kvm/mmio.c
===================================================================
--- linux-2.6.git.orig/arch/ia64/kvm/mmio.c
+++ linux-2.6.git/arch/ia64/kvm/mmio.c
@@ -158,8 +158,10 @@
vmm_transition(vcpu);
if (p->u.ioreq.state == STATE_IORESP_READY) {
- if (dir == IOREQ_READ)
- *dest = p->u.ioreq.data;
+ if (dir == IOREQ_READ) {
+ *dest = 0;
+ memcpy(dest, &p->u.ioreq.data, s);
+ }
} else
panic_vm(vcpu);
out:
next reply other threads:[~2008-05-20 9:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 9:57 Jes Sorensen [this message]
2008-05-20 10:33 ` [patch] fix zero extending for mmio ld1/2/4 emulation in KVM Matthew Chapman
2008-05-20 11:13 ` Jes Sorensen
2008-05-21 9:46 ` Zhang, Xiantao
2008-05-21 10:05 ` Avi Kivity
2008-05-22 3:45 ` Isaku Yamahata
2008-05-22 8:08 ` Jes Sorensen
2008-05-22 15:16 ` Xu, Anthony
2008-05-22 15:23 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4832A0A6.8050800@sgi.com \
--to=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox